object::stable_insert#765
Closed
gummif wants to merge 1 commit intoboostorg:developfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #765 +/- ##
===========================================
- Coverage 99.13% 98.97% -0.17%
===========================================
Files 69 69
Lines 6587 6623 +36
===========================================
+ Hits 6530 6555 +25
- Misses 57 68 +11
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
Contributor
Author
|
One thing that could reduce duplication is to implement insert in terms of stable_insert_impl using pos as end(). |
Contributor
Author
|
Stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for inserting values at any position in the object preserving order of all elements (at the cost of linear complexity). Part 2/2 of #748.
This does not have the bug #763 since care is taken to avoid allocation unless necessary.