Skip to content

Add Authentication Support#182

Open
Evanraisul wants to merge 5 commits into
bradfitz:masterfrom
Evanraisul:auth
Open

Add Authentication Support#182
Evanraisul wants to merge 5 commits into
bradfitz:masterfrom
Evanraisul:auth

Conversation

@Evanraisul

@Evanraisul Evanraisul commented Sep 30, 2024

Copy link
Copy Markdown

Signed-off-by: Muhammad Raisul Islam Evan evanraisul@gmail.com

@dormando

dormando commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

@Evanraisul do you want this change or can we close it? You've imported and vendored a ton of stuff that's unnecessary for the change itself.

The PR should be focused on just adding the feature you want.

Thanks!

@Evanraisul

Evanraisul commented Apr 4, 2025

Copy link
Copy Markdown
Author

I have updated the PR. You can review it now.

@Evanraisul Evanraisul closed this Apr 4, 2025
@Evanraisul Evanraisul reopened this Apr 4, 2025
@dormando

dormando commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

I still see a bunch of unrelated changes and also looks like you may need to pull from upstream and rebase your branch? please carefully review what your commit looks like.

sorry it's a litle odd looking still

Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
Signed-off-by: Muhammad Raisul Islam Evan <raisul@appscode.com>
@Evanraisul

Copy link
Copy Markdown
Author

Sorry for the inconvenience. I think it is okay now.
Take a look.

@dormando dormando left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting closer, thanks!

Comment thread .idea/workspace.xml Outdated
Comment thread go.mod Outdated
@Evanraisul

Copy link
Copy Markdown
Author

Resolved those stuffs. I think it is now ready for merge.

@dormando

dormando commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

Thanks! It might take a while before we review this, so please have patience.

@dormando

dormando commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

Tests are missing which is the biggest obvious thing. Before I ask that you add tests I want to review it and see if this is the right approach though.

Thanks again!

@Evanraisul

Copy link
Copy Markdown
Author

Okay, thanks. Will wait for your review.

@dormando dormando added this to the Small protocol issues milestone Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants