code-refactoring-examples/redundat-if-else.php at master · briedis/code-refactoring-examples · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
<?php

class MyClass
{
    public function doStuff()
    {
        if ($this->isValid()) {
            $status = $this->getValidStatus();
        } else {
            $status = self::STATUS_DRAFT;
        }

        $item = $this->getItemByStatus($status);

        if ($item->isCompleted()) {
            $this->notify();
            $this->export();
            return true;
        } else {
            throw new Exception;
        }
    }
}

class MyClass
{
    public function doStuff()
    {
        $status = self::STATUS_DRAFT;
        if ($this->isValid()) {
            $status = $this->getValidStatus();
        }

        $item = $this->getItemByStatus($status);

        if ($item->isCompleted()) {
            $this->notify();
            $this->export();
            return true;
        }

        throw new Exception;
    }
}