explicit cancel collation flow#1083
Merged
Merged
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=1083Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 58.97% 57.52% -1.45%
==========================================
Files 459 464 +5
Lines 76888 77109 +221
Branches 76888 77109 +221
==========================================
- Hits 45342 44357 -985
- Misses 29434 30733 +1299
+ Partials 2112 2019 -93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d84320 to
17de686
Compare
17de686 to
1aa75f5
Compare
1aa75f5 to
356af0e
Compare
Rexagon
approved these changes
May 19, 2026
… handle block from bc
…o the last applied block
…ent unplanned cancel of a newly started collator task
+ capture session_id before the validation cacellation to protect from a session update in a parallel process
40873e7 to
d266b3b
Compare
…ync to prevent incorrect behaviour in `detect_next_collation_step` on stale statuses
d266b3b to
9c7f32e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use explicit flow to cancel active collations on the block mismatch or when received a block from bc far ahead of last collated. Now we drain active collation tasks in a separate cancel task and do not relay on collator result cancellation using flags. Removed races when shard collator trying to collate next block even if cancellation requested before sync.
Collation manager code was splitted on several modules.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
None
BLOCKCHAIN CONFIGURATION MODEL CHANGES
None
COMPATIBILITY
Fully compatible
SPECIAL DEPLOYMENT ACTIONS
Not Required
PERFORMANCE IMPACT
No impact expected
TESTS
Unit Tests
No special coverage
Network Tests
No special coverage
Manual Tests
Manual tests used on devnet5
Notes/Additional Comments:
Better to review all commits except the last one separately because the last commit only moves working code from a single file to a several modules.