Merge pull request #76 from patxi1980/min_coverage

Output coverage.

Author: bruli

src/PhpGitHooks/Module/PhpUnit/Service/GuardCoverageTool.php

@@ -63,7 +63,7 @@ public function run($warningMessage)
     {
         $outputMessage = new PreCommitOutputWriter(self::CHECKING_MESSAGE);
         $this->output->write($outputMessage->getMessage());
-        
+
         $this->currentCoverage = $this->strictCoverageProcessor->process();
         $this->previousCoverage = $this->guardReader->read();
 
@@ -75,7 +75,9 @@ public function run($warningMessage)
                 $this->previousCoverage,
                 $this->currentCoverage
             )
-        ) : $this->output->writeln($outputMessage->getSuccessfulMessage());
+        ) : $this->output->writeln(
+            $outputMessage->getSuccessfulMessage() . $this->printGuardCoverage()
+        );
 
         $this->guardWriter->write($this->currentCoverage);
     }
@@ -87,4 +89,16 @@ private function isLowerCurrentCoverage()
     {
         return $this->currentCoverage < $this->previousCoverage;
     }
+
+    /**
+     * @return string
+     */
+    private function printGuardCoverage()
+    {
+        return ' <comment>[' .
+        round($this->currentCoverage, 0) .
+        '% >= ' .
+        round($this->previousCoverage, 0) .
+        '%]</comment>';
+    }
 }

src/PhpGitHooks/Module/PhpUnit/Service/StrictCoverageTool.php

@@ -23,7 +23,7 @@ class StrictCoverageTool
      * StrictCoverageTool constructor.
      *
      * @param StrictCoverageProcessorInterface $strictCoverageProcessor
-     * @param OutputInterface                  $output
+     * @param OutputInterface $output
      */
     public function __construct(StrictCoverageProcessorInterface $strictCoverageProcessor, OutputInterface $output)
     {
@@ -33,18 +33,21 @@ public function __construct(StrictCoverageProcessorInterface $strictCoverageProc
 
     /**
      * @param MinimumStrictCoverage $minimumStrictCoverage
-     * @param string                $errorMessage
+     * @param string $errorMessage
      *
+     * @return float
      * @throws InvalidStrictCoverageException
      */
     public function run(MinimumStrictCoverage $minimumStrictCoverage, $errorMessage)
     {
         $currentCoverage = $this->strictCoverageProcessor->process();
 
         if ($minimumStrictCoverage->value() > $currentCoverage) {
-                $this->output->writeln(BadJobLogoResponse::paint($errorMessage));
+            $this->output->writeln(BadJobLogoResponse::paint($errorMessage));
 
             throw new InvalidStrictCoverageException($currentCoverage, $minimumStrictCoverage->value());
         }
+
+        return $currentCoverage;
     }
 }

src/PhpGitHooks/Module/PhpUnit/Service/StrictCoverageToolExecutor.php

@@ -33,7 +33,16 @@ public function execute(MinimumStrictCoverage $minimumStrictCoverage, $errorMess
     {
         $outputMessage = new PreCommitOutputWriter(self::EXECUTE_MESSAGE);
         $this->output->write($outputMessage->getMessage());
-        $this->strictCoverageTool->run($minimumStrictCoverage, $errorMessage);
-        $this->output->writeln($outputMessage->getSuccessfulMessage());
+        $currentCoverage = $this->strictCoverageTool->run($minimumStrictCoverage, $errorMessage);
+        $this->output->writeln($outputMessage->getSuccessfulMessage() . $this->printCurrentCoverage($currentCoverage));
+    }
+
+    /**
+     * @param $currentCoverage
+     * @return string
+     */
+    private function printCurrentCoverage($currentCoverage)
+    {
+        return ' <comment>[' . round($currentCoverage, 0) . '%]</comment>';
     }
 }

src/PhpGitHooks/Module/PhpUnit/Tests/Behaviour/GuardCoverageToolCommandHandlerTest.php

@@ -67,11 +67,22 @@ public function itShouldWorksFine()
         $this->shouldProcessStrictCoverage($currentCoverage);
         $this->shouldWriteOutput($outputMessage->getMessage());
         $this->shouldReadGuardCoverage($previousCoverage);
-        $this->shouldWriteLnOutput($outputMessage->getSuccessfulMessage());
+        $this->shouldWriteLnOutput($this->buildStrictCoverageSuccessfulMessage($currentCoverage, $previousCoverage,
+            $outputMessage->getSuccessfulMessage()));
         $this->shouldWriteGuardCoverage($currentCoverage);
 
         $this->guardCoverageToolCommandHandler->handle(
             new GuardCoverageCommand(HookQuestions::PHPUNIT_GUARD_COVERAGE_MESSAGE_DEFAULT)
         );
     }
+
+    private function buildStrictCoverageSuccessfulMessage($currentCoverage, $previousCoverage, $getSuccessfulMessage)
+    {
+        return $getSuccessfulMessage .
+        ' <comment>[' .
+        round($currentCoverage, 0) .
+        '% >= ' .
+        round($previousCoverage, 0) .
+        '%]</comment>';
+    }
 }

src/PhpGitHooks/Module/PhpUnit/Tests/Behaviour/StrictCoverageToolCommandHandlerTest.php

@@ -64,11 +64,19 @@ public function itShouldWorksFine()
         $minimumStrictCoverage = MinimumStrictCoverageStub::create(90.00);
         $outputMessage = new PreCommitOutputWriter(StrictCoverageToolExecutor::EXECUTE_MESSAGE);
 
+        $coverage = 91.00;
+
         $this->shouldWriteOutput($outputMessage->getMessage());
-        $this->shouldProcessStrictCoverage(91.00);
-        $this->shouldWriteLnOutput($outputMessage->getSuccessfulMessage());
+        $this->shouldProcessStrictCoverage($coverage);
+        $this->shouldWriteLnOutput($this->buildStrictCoverageSuccessfulMessage($coverage,
+            $outputMessage->getSuccessfulMessage()));
 
         $command = new StrictCoverageCommand($minimumStrictCoverage->value(), $this->errorMessage);
         $this->strictCoverageToolCommandHandler->handle($command);
     }
+
+    private function buildStrictCoverageSuccessfulMessage($coverage, $getSuccessfulMessage)
+    {
+        return $getSuccessfulMessage . ' <comment>[' . round($coverage, 0) . '%]</comment>';
+    }
 }