Fix get errors in PhpMDHandler

bruli · bruli · commit c5179f44375c · 2016-03-11T09:30:44.000+01:00
diff --git a/src/PhpGitHooks/Infrastructure/PhpCsFixer/PhpCsFixerHandler.php b/src/PhpGitHooks/Infrastructure/PhpCsFixer/PhpCsFixerHandler.php
@@ -75,7 +75,7 @@ public function run(array $messages)
                     }
                 }
 
-                if ($errors) {
+                if (!empty($errors)) {
                     $this->outputHandler->setError($this->getErrors($errors));
                     $this->output->writeln($this->outputHandler->getError());
                     $this->output->writeln(BadJobLogo::paint($messages[MessageConfigData::KEY_ERROR_MESSAGE]));
diff --git a/src/PhpGitHooks/Infrastructure/PhpMD/PhpMDHandler.php b/src/PhpGitHooks/Infrastructure/PhpMD/PhpMDHandler.php
@@ -74,10 +74,10 @@ public function run(array $messages)
         }
 
         $errors = array_filter($errors, function ($var) {
-            return !is_null($var);
+            return trim($var);
         });
 
-        if ($errors) {
+        if (!empty($errors)) {
             $this->writeOutputError(
                 new PHPMDViolationsException(implode('', $errors)),
                 MessageConfigData::KEY_ERROR_MESSAGE

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function run(array $messages)`
`75`	`75`	`}`
`76`	`76`	`}`
`77`	`77`
`78`		`- if ($errors) {`
	`78`	`+ if (!empty($errors)) {`
`79`	`79`	`$this->outputHandler->setError($this->getErrors($errors));`
`80`	`80`	`$this->output->writeln($this->outputHandler->getError());`
`81`	`81`	`$this->output->writeln(BadJobLogo::paint($messages[MessageConfigData::KEY_ERROR_MESSAGE]));`