Always get reconized as a Virus

[Panics11]

Hello at everyone.
The ModInstaller gets reconized as an Trojan from Kaspersky Security Suite eevry time i try to strat it.
I won´t disable my anti virus for this so is there anything i could do against this?

[Assistant]

You could use a different AV. Kaspersky is extremely hypersensitive.

[megalon]

Fefeland was having the same issue with this version, and I believe it might be because I'm bundling the new MaterialSkin.dll into the BeatSaberModManager.exe with ILMerge.
I'm doing this to keep the release as a single .exe file, instead of releasing a zip file with multiple files in it.
I suppose I could release both the single .exe file and a zip file as well.

Here is the exact same release, but with the BeatSaberModManager.exe and MaterialSkin.dll as separate files. Does this also trigger your antivirus?
Release.zip

For reference here is the MaterialSkin package I'm using. I've verified the MaterialSkin.dll it downloads from the package manager is safe
https://www.nuget.org/packages/MaterialSkin/

And here is the version of ILMerge that I'm using as well. Straight from Microsoft's own website
https://www.microsoft.com/en-us/download/details.aspx?id=17630

[Panics11]

The files from this Zip doesn´t trigger the scanner..

[megalon]

Yeah, like I said, I suspect it's triggering the antivirus because it somehow detects that the BeatSaberModManager.exe has had an external DLL bundled into it.

I might start making releases as zip files from now on, but I was trying to stay with the previous convention of having a single .exe file.

[Assistant]

ILMerge is something that would definitely trigger Kaspersky from my previous experience.

Being a single .exe is one of the biggest features of the Mod Manager, though, I don't think we want to get rid of it.

[Panics11]

Maybe release both..?
Or like an installer?

[Assistant]

Releasing both would be a good solution, I think

[megalon]

I've updated the release with zip file to the unbundled version.
The auto-updater will grab both files, but it'll only attempt to run the exe, so anyone with this issue will currently have to run the exe included in the zip manually.

[Skattered]

AutoUpdater.Net Could be used to update for the people who choose to use the zip file. This would basically require a one time unzip and then the program would check for and install updates on launch.

It requires an xml and zip file that the program can access on a server (you can grab them straight from the github repo). This works great other than the fact that it doesn't really have a great way for initial install. If we found a good way to unzip the files the first time and create a desktop shortcut I think this would work great. Otherwise it does still work well, but it does break away from having the single exe launch.

I have a POC here, it has some changes that wouldn't carry over to the final but I didn't feel like making em better in case you guys didn't wanna go that route (I deleted the install button just to make an obvious change when you run the updater)

[hayarobys]

In Bitdefender, BeatSaberModInstaller is detected as a virus that "Gen: Heur.Zatk.Jn0@buS!".

[hayarobys]

But when I execute the file that separates MaterialSkin.dll separately, Window10 warning window appears once, but it is no longer detected as a virus. Thank you.

[brfrankl]

Windows "built-in" virus/trojan detector

also sees it as a Trojan. split one works fine...

[megalon]

Yeah, as far as I'm aware it's just detecting that an additional file (the MaterialSkin.dll) has been added into the .exe after it was built. ILMerge probably leaves a signature of some sort, which is triggering the antivirus.
I'm doing this because when you try to launch the BeatSaberModManager.exe without the MaterialSkin.dll present, it simply doesn't open. This would happen if the user moved the BeatSaberModManager.exe away from the MaterialSkin.dll, or if the MaterialSkin.dll was deleted. I figured it would make the most sense to just bundle the two files together.

Here is the post build event that I'm using to create the release, if anyone is interested.
https://github.com/beat-saber-modding-group/BeatSaberModInstaller/blob/727090c339f0d236da201e93378f5e3a41c0c155/BeatSaberModManager/BeatSaberModManager.csproj#L264

Moon has suggested I try https://github.com/Fody/Costura to merge the two files, and I might give that a shot. I'm also considering just moving to zip file releases instead, but I'd have to change the updater logic.

If anyone has any other suggestions for getting these two files into a single exe without it getting flagged by AV software, let me know.