Rubocop v1.68 Upgrade (#37)

* Revamp

* Pipeline fix

* upgrade autocorrects

* cop

---------

Co-authored-by: fedetaglia <[email protected]>

Author: abhinav-nain

.github/workflows/build_and_test.yml

@@ -7,21 +7,21 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [ '2.6', '2.7', '2' ]
+        ruby: ["3", "3.1", "3.2"]
     name: Test gem in ruby version ${{ matrix.ruby }}
     steps:
-    - uses: actions/checkout@v1
-    - name: Set up Ruby ${{ matrix.ruby }}
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby }}
-    - name: Build with dependencies
-      run: |
-        gem install bundler -v 2.1.4
-        bundle install
-    - name: Test with rspec
-      run: |
-        bundle exec rspec
-    - name: Lint with rubocop
-      run: |
-        bundle exec rubocop
+      - uses: actions/checkout@v1
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Build with dependencies
+        run: |
+          gem install bundler -v 2.5.16
+          bundle install
+      - name: Test with rspec
+        run: |
+          bundle exec rspec
+      - name: Lint with rubocop
+        run: |
+          bundle exec rubocop

.ruby-version

@@ -1 +1 @@
-2.7.2
+3.3.2

Gemfile.lock

@@ -1,68 +1,70 @@
 PATH
   remote: .
   specs:
-    rubocop-bugcrowd (0.1.0)
-      rubocop
+    rubocop-bugcrowd (1.0.0)
+      rubocop (= 1.68.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    byebug (11.1.1)
-    coderay (1.1.2)
-    diff-lcs (1.3)
-    method_source (0.9.2)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    byebug (11.1.3)
+    coderay (1.1.3)
+    diff-lcs (1.5.1)
+    json (2.8.1)
+    language_server-protocol (3.17.0.3)
+    method_source (1.1.0)
+    parallel (1.26.3)
+    parser (3.3.6.0)
       ast (~> 2.4.1)
       racc
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.8.0)
+    pry (0.14.2)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.10.1)
       byebug (~> 11.0)
-      pry (~> 0.10)
-    racc (1.7.1)
+      pry (>= 0.13, < 0.15)
+    racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.0.1)
-    regexp_parser (2.8.1)
-    rexml (3.2.6)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.1)
-      rspec-support (~> 3.9.1)
-    rspec-expectations (3.9.0)
+    rake (13.2.1)
+    regexp_parser (2.9.2)
+    rspec (3.13.0)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.2)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.2)
-    rubocop (0.93.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.1)
+    rubocop (1.68.0)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 2.7.1.5)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
-      rexml
-      rubocop-ast (>= 0.6.0)
+      regexp_parser (>= 2.4, < 3.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (1.29.0)
-      parser (>= 3.2.1.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.34.1)
+      parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
-    unicode-display_width (1.8.0)
+    unicode-display_width (2.6.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  pry-byebug
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  rubocop (~> 0.93)
+  pry-byebug (= 3.10.1)
+  rake
+  rspec
+  rubocop (= 1.68.0)
   rubocop-bugcrowd!
 
 BUNDLED WITH
-   2.1.4
+   2.5.16

Rakefile

@@ -7,8 +7,6 @@ RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
 
-require 'rspec/core/rake_task'
-
 RSpec::Core::RakeTask.new(:spec) do |spec|
   spec.pattern = FileList['spec/**/*_spec.rb']
 end

lib/rubocop/bugcrowd/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Bugcrowd
-    VERSION = '0.1.0'
+    VERSION = '1.0.0'
   end
 end

lib/rubocop/cop/bugcrowd/add_index_non_concurrently.rb

@@ -16,7 +16,7 @@ module Bugcrowd
       #
       #   # good
       #   add_index :table_name, :column, zibble: :bibble, algorithm: :concurrently
-      class AddIndexNonConcurrently < Cop
+      class AddIndexNonConcurrently < Base
         include Database
 
         MSG = 'By default, Postgres locks writes to a table while creating an index on it ' \

lib/rubocop/cop/bugcrowd/avoid_sample_in_specs.rb

@@ -18,7 +18,7 @@ module Bugcrowd
       #   expect(thing).to have_some_property
       #   expect(thing1).to have_some_property
       #
-      class AvoidSampleInSpecs < Cop
+      class AvoidSampleInSpecs < Base
         MSG = 'Avoid using sample in spec as it can cause non-deterministic behavior'
 
         def_node_matcher :sample?, <<~PATTERN

lib/rubocop/cop/bugcrowd/can_with_class_const.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Bugcrowd
-      class CanWithClassConst < RuboCop::Cop::Cop
+      class CanWithClassConst < Base
         MSG = <<~COPCONTENT
           🚨 Don't call can? with a class constant, as it will unexpectedly pass. Use an instance instead. (https://github.com/CanCanCommunity/cancancan/wiki/Defining-Abilities-with-Blocks#only-for-object-attributes) 🚨
         COPCONTENT

lib/rubocop/cop/bugcrowd/constant_assignment_specs.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Bugcrowd
-      class ConstantAssignmentSpecs < RuboCop::Cop::Cop
+      class ConstantAssignmentSpecs < Base
         MSG = <<~COPCONTENT
           🚨  Constants persist across specs due to global nature 🚨
         COPCONTENT

lib/rubocop/cop/bugcrowd/controller_specs.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Bugcrowd
-      class ControllerSpecs < RuboCop::Cop::Cop
+      class ControllerSpecs < Base
         MSG = <<~COPCONTENT
           🚨  Controller specs are deprecated, please create request specs instead 🚨
           See https://everydayrails.com/2016/08/29/replace-rspec-controller-tests.html for an overview