Raise max captured thread count to 1000 (kstenerud#664)

* Raise max captured thread count to 1000

* Use MAX_CAPTURED_THREADS in unit tests

Author: DariaKunoichi

Samples/Common/Sources/CrashTriggers/KSCrashTriggersList.mm

@@ -95,7 +95,7 @@ + (void)trigger_signal_abort
 
 + (void)trigger_other_manyThreads
 {
-    NSUInteger const threadsCount = 200;
+    NSUInteger const threadsCount = 1005;
     static NSMutableArray *allThreads = [NSMutableArray arrayWithCapacity:threadsCount + 1];
 
     for (NSUInteger idx = 0; idx < threadsCount; ++idx) {

Sources/KSCrashRecording/KSCrashReportStoreC.c

@@ -209,7 +209,7 @@ int kscrs_getReportIDs(int64_t *reportIDs, int count, const KSCrashReportStoreCC
 static char *readReportAtPath(const char *path)
 {
     char *rawReport;
-    ksfu_readEntireFile(path, &rawReport, NULL, 2000000);
+    ksfu_readEntireFile(path, &rawReport, NULL, 20000000);
     if (rawReport == NULL) {
         KSLOG_ERROR("Failed to load report at path: %s", path);
         return NULL;

Sources/KSCrashRecordingCore/KSJSONCodecObjC.m

@@ -411,7 +411,7 @@ + (NSData *)encode:(id)object options:(KSJSONEncodeOption)encodeOptions error:(N
 + (id)decode:(NSData *)JSONData options:(KSJSONDecodeOption)decodeOptions error:(NSError *__autoreleasing *)error
 {
     KSJSONCodec *codec = [self codecWithEncodeOptions:0 decodeOptions:decodeOptions];
-    NSMutableData *stringData = [NSMutableData dataWithLength:10001];
+    NSMutableData *stringData = [NSMutableData dataWithLength:20000000];
     int errorOffset;
     int result = ksjson_decode(JSONData.bytes, (int)JSONData.length, stringData.mutableBytes, (int)stringData.length,
                                codec.callbacks, (__bridge void *)codec, &errorOffset);

Sources/KSCrashRecordingCore/KSMachineContext.c

@@ -83,17 +83,16 @@ static inline bool getThreadList(KSMachineContext *context)
     }
     KSLOG_TRACE("Got %d threads", context->threadCount);
     mach_msg_type_number_t threadCount = actualThreadCount;
-    mach_msg_type_number_t maxThreadCount = sizeof(context->allThreads) / sizeof(context->allThreads[0]);
-    if (threadCount > maxThreadCount) {
-        KSLOG_ERROR("Thread count %d is higher than maximum of %d", threadCount, maxThreadCount);
-        for (mach_msg_type_number_t idx = maxThreadCount; idx < threadCount; ++idx) {
+    if (threadCount > MAX_CAPTURED_THREADS) {
+        KSLOG_ERROR("Thread count %d is higher than maximum of %d", threadCount, MAX_CAPTURED_THREADS);
+        for (mach_msg_type_number_t idx = MAX_CAPTURED_THREADS; idx < threadCount; ++idx) {
             if (threads[idx] == context->thisThread) {
                 // If crashed thread is outside of threads limit we place it at the end of the list
-                threads[maxThreadCount - 1] = threads[idx];
+                threads[MAX_CAPTURED_THREADS - 1] = threads[idx];
                 break;
             }
         }
-        threadCount = maxThreadCount;
+        threadCount = MAX_CAPTURED_THREADS;
     }
     for (mach_msg_type_number_t i = 0; i < threadCount; i++) {
         context->allThreads[i] = threads[i];

Sources/KSCrashRecordingCore/include/KSMachineContext_Apple.h

@@ -37,6 +37,8 @@
 extern "C" {
 #endif
 
+#define MAX_CAPTURED_THREADS 1000
+
 #ifdef __arm64__
 #define STRUCT_MCONTEXT_L _STRUCT_MCONTEXT64
 #else
@@ -45,7 +47,7 @@ extern "C" {
 
 typedef struct KSMachineContext {
     thread_t thisThread;
-    thread_t allThreads[100];
+    thread_t allThreads[MAX_CAPTURED_THREADS];
     int threadCount;
     bool isCrashedContext;
     bool isCurrentThread;

Tests/KSCrashRecordingCoreTests/KSMachineContext_Tests.m

@@ -47,4 +47,21 @@ - (void)testSuspendResumeThreads
     ksmc_resumeEnvironment(threads1, numThreads1);
 }
 
+- (void)startTheBackgroundJob
+{
+    sleep(5);
+}
+
+- (void)testMaxThreadsInContext
+{
+    KSMachineContext machineContext = { 0 };
+    int threadsToCreate = MAX_CAPTURED_THREADS + 5;
+    for (int i = 0; i < threadsToCreate; ++i) {
+        [NSThread detachNewThreadSelector:@selector(startTheBackgroundJob) toTarget:self withObject:nil];
+    }
+
+    ksmc_getContextForThread(ksthread_self(), &machineContext, true);
+    XCTAssertEqual(machineContext.threadCount, MAX_CAPTURED_THREADS);
+}
+
 @end