Skip to content

Commit 0a3c396

Browse files
twometrestevetwometresteve
authored
Merge pull request #533 from bugsnag/tms/remove-steps-2
Remove redundant scenario steps (part 2)
2 parents 686dd5b + a3023a2 commit 0a3c396

16 files changed

+0
-206
lines changed

‎features/default/automatic/automatic_app_start.feature‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ Feature: Automatic app start instrumentation spans
1111
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
1212
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
1313
* every span field "kind" equals 1
14-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
15-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
1614
* a span string attribute "bugsnag.app_start.type" equals "cold"
1715
* a span string attribute "bugsnag.phase" equals "App launching - pre main()"
1816
* a span string attribute "bugsnag.phase" equals "App launching - post main()"
@@ -54,8 +52,6 @@ Feature: Automatic app start instrumentation spans
5452
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
5553
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
5654
* every span field "kind" equals 1
57-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
58-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
5955
* a span string attribute "bugsnag.app_start.type" equals "cold"
6056
* a span string attribute "bugsnag.phase" equals "App launching - pre main()"
6157
* a span string attribute "bugsnag.phase" equals "App launching - post main()"
@@ -109,8 +105,6 @@ Feature: Automatic app start instrumentation spans
109105
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
110106
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
111107
* every span field "kind" equals 1
112-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
113-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
114108
* a span string attribute "bugsnag.app_start.type" equals "cold"
115109
* a span string attribute "bugsnag.phase" equals "App launching - pre main()"
116110
* a span string attribute "bugsnag.phase" equals "App launching - post main()"

‎features/default/automatic/automatic_network.feature‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ Feature: Automatic network instrumentation spans
1919
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
2020
* a span field "kind" equals 1
2121
* a span field "kind" equals 3
22-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
23-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
2422
* a span bool attribute "bugsnag.span.first_class" is true
2523
* a span bool attribute "bugsnag.span.first_class" does not exist
2624
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
@@ -44,8 +42,6 @@ Feature: Automatic network instrumentation spans
4442
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
4543
* a span field "kind" equals 1
4644
* a span field "kind" equals 3
47-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
48-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
4945
* a span bool attribute "bugsnag.span.first_class" is true
5046
* a span bool attribute "bugsnag.span.first_class" does not exist
5147
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
@@ -66,8 +62,6 @@ Feature: Automatic network instrumentation spans
6662
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
6763
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
6864
* every span field "kind" equals 3
69-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
70-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
7165
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
7266
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
7367
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.version" matches the regex "[0-9]+\.[0-9]+\.[0-9]+"
@@ -96,8 +90,6 @@ Feature: Automatic network instrumentation spans
9690
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
9791
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
9892
* every span field "kind" equals 3
99-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
100-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
10193
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
10294
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
10395
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.version" matches the regex "[0-9]+\.[0-9]+\.[0-9]+"
@@ -113,8 +105,6 @@ Feature: Automatic network instrumentation spans
113105
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
114106
* a span field "kind" equals 1
115107
* a span field "kind" equals 3
116-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
117-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
118108
* a span string attribute "bugsnag.instrumentation_message" exists
119109
* a span string attribute "bugsnag.instrumentation_message" matches the regex "Error.*"
120110
* a span bool attribute "bugsnag.span.first_class" is true
@@ -141,8 +131,6 @@ Feature: Automatic network instrumentation spans
141131
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
142132
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
143133
* every span field "kind" equals 3
144-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
145-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
146134
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
147135
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
148136
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.version" matches the regex "[0-9]+\.[0-9]+\.[0-9]+"
@@ -162,8 +150,6 @@ Feature: Automatic network instrumentation spans
162150
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
163151
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
164152
* every span field "kind" equals 3
165-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
166-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
167153
* the trace payload field "resourceSpans.0.resource" string attribute "service.name" matches the regex "com.bugsnag.fixtures.cocoaperformance(xcframework)?"
168154
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.name" equals "bugsnag.performance.cocoa"
169155
* the trace payload field "resourceSpans.0.resource" string attribute "telemetry.sdk.version" matches the regex "[0-9]+\.[0-9]+\.[0-9]+"
@@ -180,8 +166,6 @@ Feature: Automatic network instrumentation spans
180166
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
181167
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
182168
* every span field "kind" equals 3
183-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
184-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
185169
* a span string attribute "http.url" equals "https://bugsnag.com"
186170
* a span string attribute "http.url" equals "https://bugsnag.com/changed"
187171

@@ -196,8 +180,6 @@ Feature: Automatic network instrumentation spans
196180
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
197181
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
198182
* every span field "kind" equals 3
199-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
200-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
201183
* a span string attribute "http.url" equals "https://bugsnag.com"
202184

203185
Scenario: AutoInstrumentNetworkTracePropagationScenario: Allow All

‎features/default/automatic/automatic_spans_generic_view_load.feature‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ Feature: Automatic instrumentation spans AutoInstrumentGenericViewLoadScenario
2626
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
2727
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
2828
* every span field "kind" equals 1
29-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
30-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
3129
* a span string attribute "bugsnag.span.category" equals "view_load"
3230
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
3331
* a span string attribute "bugsnag.view.name" equals "Fixture.AutoInstrumentGenericViewLoadScenario_ViewController<Fixture.AutoInstrumentGenericViewLoadScenario_GenericsClass>"
@@ -62,8 +60,6 @@ Feature: Automatic instrumentation spans AutoInstrumentGenericViewLoadScenario
6260
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
6361
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
6462
* every span field "kind" equals 1
65-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
66-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
6763
* a span string attribute "bugsnag.span.category" equals "view_load"
6864
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
6965
* a span string attribute "bugsnag.view.name" equals "Fixture.GenericViewController<Swift.Int>"

‎features/default/automatic/automatic_swift_ui.feature‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ Feature: Automatic swift UI spans
1111
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
1212
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
1313
* every span field "kind" equals 1
14-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
15-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
1614
* a span string attribute "bugsnag.span.category" equals "view_load"
1715
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
1816
* a span string attribute "bugsnag.view.name" equals "My VStack view"
@@ -33,8 +31,6 @@ Feature: Automatic swift UI spans
3331
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
3432
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
3533
* every span field "kind" equals 1
36-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
37-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
3834
* a span string attribute "bugsnag.span.category" equals "view_load"
3935
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
4036
* a span string attribute "bugsnag.view.name" equals "My VStack view"
@@ -52,8 +48,6 @@ Feature: Automatic swift UI spans
5248
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
5349
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
5450
* every span field "kind" equals 1
55-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
56-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
5751
* a span string attribute "bugsnag.span.category" equals "view_load"
5852
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
5953
* every span string attribute "bugsnag.view.name" equals "Text"
@@ -69,8 +63,6 @@ Feature: Automatic swift UI spans
6963
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
7064
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
7165
* every span field "kind" equals 1
72-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
73-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
7466
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
7567
* a span string attribute "bugsnag.view.name" equals "vstack1"
7668
* a span string attribute "bugsnag.view.name" equals "text1"
@@ -85,8 +77,6 @@ Feature: Automatic swift UI spans
8577
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
8678
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
8779
* every span field "kind" equals 1
88-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
89-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
9080
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
9181
* a span string attribute "bugsnag.view.name" equals "vstack1"
9282
* a span string attribute "bugsnag.view.name" equals "text1"
@@ -100,8 +90,6 @@ Feature: Automatic swift UI spans
10090
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
10191
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
10292
* every span field "kind" equals 1
103-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
104-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
10593
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
10694
* a span string attribute "bugsnag.view.name" equals "vstack1"
10795
* a span string attribute "bugsnag.view.name" equals "text1"
@@ -116,8 +104,6 @@ Feature: Automatic swift UI spans
116104
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
117105
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
118106
* every span field "kind" equals 1
119-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
120-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
121107
* every span string attribute "bugsnag.span.category" equals "view_load_phase"
122108
* a span string attribute "bugsnag.view.name" equals "vstack1"
123109
* a span string attribute "bugsnag.view.name" equals "text1"
@@ -129,8 +115,6 @@ Feature: Automatic swift UI spans
129115
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
130116
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
131117
* every span field "kind" equals 1
132-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
133-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
134118
* a span string attribute "bugsnag.span.category" equals "view_load"
135119
* a span string attribute "bugsnag.span.category" equals "view_load_phase"
136120
* every span string attribute "bugsnag.view.name" equals "vstack1"

‎features/default/automatic/automatic_view_load.feature‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ Feature: Automatic view load instrumentation spans
2525
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
2626
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
2727
* every span field "kind" equals 1
28-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
29-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
3028
* a span string attribute "bugsnag.span.category" equals "view_load"
3129
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
3230
* a span string attribute "bugsnag.view.name" equals "Fixture.AutoInstrumentViewLoadScenario_ViewController"
@@ -95,8 +93,6 @@ Feature: Automatic view load instrumentation spans
9593
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
9694
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
9795
* every span field "kind" equals 1
98-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
99-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
10096
* a span string attribute "bugsnag.span.category" equals "view_load"
10197
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
10298
* a span string attribute "bugsnag.view.name" equals "Fixture.AutoInstrumentSubViewLoadScenario_ViewController"
@@ -159,8 +155,6 @@ Feature: Automatic view load instrumentation spans
159155
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
160156
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
161157
* every span field "kind" equals 1
162-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
163-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
164158
* a span string attribute "bugsnag.span.category" equals "view_load"
165159
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
166160
* a span string attribute "bugsnag.view.name" equals "Fixture.AutoInstrumentTabViewLoadScenario_SubViewController"
@@ -206,8 +200,6 @@ Feature: Automatic view load instrumentation spans
206200
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
207201
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
208202
* every span field "kind" equals 1
209-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
210-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
211203
* a span string attribute "bugsnag.span.category" equals "view_load"
212204
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
213205
* a span string attribute "bugsnag.view.name" equals "Fixture.AutoInstrumentNavigationViewLoadScenario_SubViewController"
@@ -255,8 +247,6 @@ Feature: Automatic view load instrumentation spans
255247
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
256248
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
257249
* every span field "kind" equals 1
258-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
259-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
260250
* a span string attribute "bugsnag.span.category" equals "view_load"
261251
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
262252
* a span string attribute "bugsnag.view.name" equals "Fixture.AutoInstrumentPreLoadedViewLoadScenario_ViewController (preload)"
@@ -295,8 +285,6 @@ Feature: Automatic view load instrumentation spans
295285
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
296286
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
297287
* every span field "kind" equals 1
298-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
299-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
300288
* a span string attribute "bugsnag.span.category" equals "view_load"
301289
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
302290
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewDidLoadDoesntTriggerScenario_ViewController"
@@ -335,8 +323,6 @@ Feature: Automatic view load instrumentation spans
335323
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
336324
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
337325
* every span field "kind" equals 1
338-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
339-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
340326
* a span string attribute "bugsnag.span.category" equals "view_load"
341327
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewController"
342328
* a span string attribute "bugsnag.view.name" equals "Fixture.ViewDidLoadDoesntTriggerScenario_ViewController"
@@ -380,8 +366,6 @@ Feature: Automatic view load instrumentation spans
380366
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
381367
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
382368
* every span field "kind" equals 1
383-
* every span field "startTimeUnixNano" matches the regex "^[0-9]+$"
384-
* every span field "endTimeUnixNano" matches the regex "^[0-9]+$"
385369
* a span string attribute "bugsnag.phase" equals "loadView"
386370
* a span string attribute "bugsnag.phase" equals "viewDidLoad"
387371
* a span string attribute "bugsnag.phase" equals "viewWillAppear"

0 commit comments

Comments
 (0)