Skip to content

Commit 817ec59

Browse files
author
Steve Kirkland
committed
Remove redundant scenario steps (part 1)
1 parent 676bbc4 commit 817ec59

File tree

7 files changed

+0
-47
lines changed

7 files changed

+0
-47
lines changed

features/default/attributes.feature

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Feature: Spans with custom attributes
44
Given I run "SetAttributesScenario"
55
And I wait to receive at least 1 span
66
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
7-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
87
* a span field "name" equals "SetAttributesScenario"
98
* a span string attribute "a" equals "xyz"
109
* every span bool attribute "b" does not exist
@@ -21,7 +20,6 @@ Feature: Spans with custom attributes
2120
Given I run "SetAttributesWithLimitsScenario"
2221
And I wait to receive at least 1 span
2322
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
24-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
2523
* a span field "name" equals "SetAttributesWithLimitsScenario"
2624
* a span string attribute "a" equals "1234567890*** 1 CHARS TRUNCATED"
2725
* a span array attribute "b" contains the integer value 1 at index 0
@@ -33,6 +31,5 @@ Feature: Spans with custom attributes
3331
Given I run "SetAttributeCountLimitScenario"
3432
And I wait to receive at least 1 span
3533
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
36-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
3734
* a span field "name" equals "SetAttributeCountLimitScenario"
3835
* every span string attribute "a" does not exist

features/default/configuration.feature

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ Feature: Configuration overrides
66
Then the trace "Content-Type" header equals "application/json"
77
* the trace "Bugsnag-Integrity" header matches the regex "^sha1 [A-Fa-f0-9]{40}$"
88
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
9-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
109
* every span field "name" equals "AppDataOverrideScenario"
1110
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
1211
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
@@ -34,7 +33,6 @@ Feature: Configuration overrides
3433
Then the trace "Content-Type" header equals "application/json"
3534
* the trace "Bugsnag-Integrity" header matches the regex "^sha1 [A-Fa-f0-9]{40}$"
3635
* the trace "Bugsnag-Span-Sampling" header is not present
37-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
3836
* every span field "name" equals "FixedSamplingProbabilitySpan1"
3937
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
4038
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
@@ -46,7 +44,6 @@ Feature: Configuration overrides
4644
And I invoke "step2"
4745
And I wait to receive at least 1 span
4846
* the trace "Bugsnag-Span-Sampling" header is not present
49-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
5047
* every span field "name" equals "FixedSamplingProbabilitySpan2"
5148
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
5249
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"

features/default/early_spans.feature

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Feature: Early spans
44
Given I run "EarlySpanOnEndScenario"
55
And I wait to receive 1 span
66
Then the trace "Content-Type" header equals "application/json"
7-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
87
* every span field "parentSpanId" does not exist
98
* a span field "name" equals "[HTTP/GET]"
109
* a span string attribute "http.flavor" exists
@@ -26,7 +25,6 @@ Feature: Early spans
2625
And I wait to receive 5 spans
2726
Then the trace "Content-Type" header equals "application/json"
2827
* the trace "Bugsnag-Span-Sampling" header equals "1:5"
29-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
3028
* a span field "name" equals "[AppStart/iOSCold]"
3129
* a span field "name" equals "[AppStartPhase/App launching - pre main()]"
3230
* a span field "name" equals "[AppStartPhase/App launching - post main()]"

features/default/initial-p-value.feature

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ Feature: Initial P values
55
And I run "InitialPScenario"
66
And I wait to receive a sampling request
77
* the sampling request "Bugsnag-Span-Sampling" header equals "1:0"
8-
* the sampling request "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
98
* the sampling request payload field "resourceSpans" is an array with 0 elements
109
Then I set the sampling probability for the next traces to "0"
1110
Then I invoke "step2"
@@ -17,11 +16,9 @@ Feature: Initial P values
1716
And I wait to receive a sampling request
1817

1918
Then the sampling request "Bugsnag-Span-Sampling" header equals "1:0"
20-
* the sampling request "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
2119

2220
Then I wait to receive at least 1 span
2321
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
24-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
2522
* every span field "name" equals "First"
2623
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
2724
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
@@ -32,7 +29,6 @@ Feature: Initial P values
3229
And I invoke "step2"
3330
And I wait to receive at least 1 span
3431
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
35-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
3632
* every span field "name" equals "Second"
3733
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"
3834
* every span field "traceId" matches the regex "^[A-Fa-f0-9]{32}$"
@@ -44,5 +40,4 @@ Feature: Initial P values
4440
Given I run "ProbabilityExpiryScenario"
4541
And I wait to receive at least 1 sampling request
4642
* the sampling request "Bugsnag-Span-Sampling" header equals "1:0"
47-
* the sampling request "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
4843
* the sampling request payload field "resourceSpans" is an array with 0 elements

features/default/limits.feature

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ Feature: Checking payloads limits
77
Then the trace "Content-Type" header equals "application/json"
88
* the trace "Bugsnag-Integrity" header matches the regex "^sha1 [A-Fa-f0-9]{40}$"
99
* the trace "Bugsnag-Span-Sampling" header equals "1:1"
10-
* the trace "Bugsnag-Sent-At" header matches the regex "^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\.\d\d\dZ$"
1110
* the trace "Bugsnag-Uncompressed-Content-Length" header matches the regex "^[0-9]+$"
1211
* every span field "name" equals "MaxPayloadSizeScenario"
1312
* every span field "spanId" matches the regex "^[A-Fa-f0-9]{16}$"

0 commit comments

Comments
 (0)