Skip to content

Commit 768a5eb

Browse files
committed
Merge PR OCA#1124 into 14.0
Signed-off-by simahawk
2 parents 54b439e + 8fcec94 commit 768a5eb

File tree

4 files changed

+19
-15
lines changed

4 files changed

+19
-15
lines changed

edi_oca/models/edi_exchange_consumer_mixin.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,8 @@ def _edi_send_via_edi(self, exchange_type, backend=None, force=False, **kw):
313313
exchange_record = self._edi_create_exchange_record(
314314
exchange_type, backend=backend
315315
)
316-
if exchange_record:
316+
# If quick exec is on, `exchange_generate_send` already ran
317+
if exchange_record and not exchange_type.quick_exec:
317318
exchange_record.action_exchange_generate_send(**kw)
318319

319320
# TODO: full unit test coverage

edi_sale_oca/views/res_partner.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<field name="arch" type="xml">
1010
<group name="edi_main" position="after">
1111
<group name="sale" string="Sale">
12-
<field name="edi_sale_conf_ids" nolabel="1">
12+
<field name="edi_sale_conf_ids" colspan="6" nolabel="1">
1313
<tree>
1414
<field name="name" />
1515
<field name="trigger_id" />

edi_xml_oca/tests/common.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
import xmlunittest
88

9+
from odoo.addons.component.tests.common import SavepointComponentCase
10+
911

1012
class XMLTestCaseMixin(xmlunittest.XmlTestMixin):
1113
def _dev_write_example_file(self, test_file, filename, content):
@@ -22,3 +24,15 @@ def read_test_file(self, filename):
2224
path = os.path.join(os.path.dirname(__file__), "examples", filename)
2325
with open(path, "r") as thefile:
2426
return thefile.read()
27+
28+
29+
class XMLComponentTestCase(SavepointComponentCase, XMLTestCaseMixin):
30+
@classmethod
31+
def setUpClass(cls):
32+
super().setUpClass()
33+
cls.backend = cls.env.ref("edi_oca.demo_edi_backend")
34+
cls.handler = cls.backend._find_component(
35+
cls.backend._name,
36+
["edi.xml"],
37+
work_ctx={"schema_path": "edi_xml_oca:tests/fixtures/Test.xsd"},
38+
)

edi_xml_oca/tests/test_xml.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
# @author: Simone Orsi <[email protected]>
33
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
44

5-
from odoo.addons.component.tests.common import SavepointComponentCase
65

7-
from .common import XMLTestCaseMixin
6+
from .common import XMLComponentTestCase
87

98
TEST_XML = """<?xml version="1.0" encoding="UTF-8"?>
109
<xs:element
@@ -15,17 +14,7 @@
1514
"""
1615

1716

18-
class XMLTestCase(SavepointComponentCase, XMLTestCaseMixin):
19-
@classmethod
20-
def setUpClass(cls):
21-
super().setUpClass()
22-
cls.backend = cls.env.ref("edi_oca.demo_edi_backend")
23-
cls.handler = cls.backend._find_component(
24-
cls.backend._name,
25-
["edi.xml"],
26-
work_ctx={"schema_path": "edi_xml_oca:tests/fixtures/Test.xsd"},
27-
)
28-
17+
class XMLTestCase(XMLComponentTestCase):
2918
def test_xml_schema_fail(self):
3019
with self.assertRaises(ValueError):
3120
self.backend._find_component(

0 commit comments

Comments
 (0)