Fixes #133, creates API for Maps and Lists for consistent data checking #154
Conversation
| // what do we do here? self.rejectedUpdatedList ? | ||
| console.log("REJECTED", e); | ||
| console.error("baseConnect.getListData rejected", e); | ||
| self.rejectedUpdatedInstance(list, e); |
There was a problem hiding this comment.
I think this should be rejectedUpdatedList?
There was a problem hiding this comment.
I don't, "instance" was the best neutral name I could come up with to apply to both a map and a list.
| var behavior = { | ||
| init: function() { | ||
| // If List and Map are on the behavior, then we go ahead and add the | ||
| // isConsistent API information. |
There was a problem hiding this comment.
We should probably avoid having fall-through-cache know anything about can-connect/can/map. Can you think of a way to avoid this?
There was a problem hiding this comment.
Off the top of my head no. Based on the suggested requirements, these features would be specific to maps and lists, and made sense to me that if we wanted to have these function features available in templates.
Do you have any suggestions?
|
Thanks @imjoshdean. Please let me know if you have any thoughts about this stuff. |
|
Thoughts provided inline! |
|
@justinbmeyer this is waiting review. |
For #133:
If
can/mapis being used alongsidefall-through-cache, new attributes will be added toMaps andLists.isConsistent()will return true if the data is actively in sync with the data from the server, false if it's relying onfall-back-cache's cached data.inconsistencyReasonwill return the base connection's rejected promise error, should there be one.