Skip to content

Commit 5be8568

Browse files
committed
Actually add the requested comment from review
The review of #6380 suggested an expanded comment that I wrote but apparently didn't hit "save" in the editor for. Doh! This adds it.
1 parent 77808cd commit 5be8568

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

toolchain/driver/clang_runtimes.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,10 @@ auto ClangRuntimesBuilderBase::ArchiveBuilder::CompileMember(
199199
llvm::fmt_consume(obj_result.takeError())));
200200
}
201201

202-
// Unlink the object file once we've read it. However, we log and ignore
203-
// any errors here as they aren't fatal.
202+
// Unlink the object file once we've read it -- we only want to retain the
203+
// copy inside the archive member and there's no advantage to using
204+
// thin-archives or something else that leaves the object file in place.
205+
// However, we log and ignore any errors here as they aren't fatal.
204206
auto unlink_result = builder_->runtimes_builder_->dir().Unlink(obj_path);
205207
if (!unlink_result.ok()) {
206208
CARBON_VLOG("Unable to unlink object file `{0}`: {1}\n", obj_path,

0 commit comments

Comments
 (0)