File tree Expand file tree Collapse file tree 1 file changed +4
-2
lines changed Expand file tree Collapse file tree 1 file changed +4
-2
lines changed Original file line number Diff line number Diff line change @@ -199,8 +199,10 @@ auto ClangRuntimesBuilderBase::ArchiveBuilder::CompileMember(
199199 llvm::fmt_consume (obj_result.takeError ())));
200200 }
201201
202- // Unlink the object file once we've read it. However, we log and ignore
203- // any errors here as they aren't fatal.
202+ // Unlink the object file once we've read it -- we only want to retain the
203+ // copy inside the archive member and there's no advantage to using
204+ // thin-archives or something else that leaves the object file in place.
205+ // However, we log and ignore any errors here as they aren't fatal.
204206 auto unlink_result = builder_->runtimes_builder_ ->dir ().Unlink (obj_path);
205207 if (!unlink_result.ok ()) {
206208 CARBON_VLOG (" Unable to unlink object file `{0}`: {1}\n " , obj_path,
You can’t perform that action at this time.
0 commit comments