Skip to content

Commit 5e391e7

Browse files
chandlercdwblaikie
andauthored
Apply suggestions from code review
Co-authored-by: David Blaikie <[email protected]>
1 parent 8aa80b0 commit 5e391e7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

toolchain/driver/clang_runtimes.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ ClangResourceDirBuilder::ClangResourceDirBuilder(
228228
result_ = std::move(build_dir_or_error).error();
229229
return;
230230
}
231-
auto build_dir = *(std::move(build_dir_or_error));
231+
auto build_dir = *std::move(build_dir_or_error);
232232
if (std::holds_alternative<std::filesystem::path>(build_dir)) {
233233
// Found cached build.
234234
result_ = std::get<std::filesystem::path>(std::move(build_dir));
@@ -250,7 +250,7 @@ ClangResourceDirBuilder::ClangResourceDirBuilder(
250250
"-fvisibility=hidden",
251251
"-w",
252252
});
253-
tasks_.async([this]() mutable { Setup(); });
253+
tasks_.async([this]() { Setup(); });
254254
}
255255

256256
auto ClangResourceDirBuilder::CollectBuiltinsSrcFiles()
@@ -329,10 +329,10 @@ auto ClangResourceDirBuilder::Setup() -> void {
329329
result_ = std::move(lib_dir_result).error();
330330
return;
331331
}
332-
lib_dir_ = *(std::move(lib_dir_result));
332+
lib_dir_ = *std::move(lib_dir_result);
333333

334334
Latch::Handle latch_handle = step_counter_.Init(
335-
[this]() mutable { tasks_.async([this]() mutable { Finish(); }); });
335+
[this] { tasks_.async([this] { Finish(); }); });
336336

337337
// For Linux targets, the system libc (typically glibc) doesn't necessarily
338338
// provide the CRT begin/end files, and so we need to build them.

toolchain/driver/clang_runtimes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class ClangRuntimesBuilderBase::ArchiveBuilder {
129129
// Start building the archive, with a latch handle to signal its completion.
130130
//
131131
// This will launch asynchronous tasks on the `builder_->tasks` task group to
132-
// first compile all the member sof the archive, and once compiled to put them
132+
// first compile all the members of the archive, and once compiled to put them
133133
// into the archive file. Only when this last step is complete will the
134134
// provided handle be destroyed, signaling this step of any concurrent build
135135
// is done.

0 commit comments

Comments
 (0)