Update LLVM and update APIs #6147
Conversation
chandlerc
force-pushed
the
update-llvm
branch
from
b5cfa3d to
7659a9a
Compare
| llvm::Triple target_triple(options_.codegen_options.target); | ||
| std::string target_error; | ||
| const llvm::Target* target = llvm::TargetRegistry::lookupTarget( | ||
| llvm::Triple(options_.codegen_options.target), target_error); | ||
| const llvm::Target* target = | ||
| llvm::TargetRegistry::lookupTarget(target_triple, target_error); |
There was a problem hiding this comment.
No objection to the change, but I'm surprised this was necessary -- it looks like the old code would have still compiled and worked. Did it not?
There was a problem hiding this comment.
Ah, looks like this issue was fixed in 5714f4d and I guess this PR was written against an older version. Nothing to see here, then.
There was a problem hiding this comment.
Yep, this should be gone now.
| static auto MapTagType(Context& context, const clang::TagType& type) | ||
| -> TypeExpr { | ||
| auto* tag_decl = type.getOriginalDecl(); | ||
| auto* tag_decl = type.getDecl(); |
There was a problem hiding this comment.
Looks like the version of LLVM we're moving to doesn't have this rename yet (llvm/llvm-project@b516dcc landed on October 15, but this PR is picking an LLVM revision from September).
There was a problem hiding this comment.
Now that this PR is ready for review, it includes a sufficiently new version of LLVM for this rename.
chandlerc
force-pushed
the
update-llvm
branch
from
7659a9a to
9938ca3
Compare
This also updates the patch file for compiler-rt as upstream has changed a bit. No functional change.
chandlerc
force-pushed
the
update-llvm
branch
from
9938ca3 to
53a2e98
Compare
chandlerc
left a comment
chandlerc
left a comment
There was a problem hiding this comment.
This should now be ready to review. Sorry for confusion with earlier versions.
| static auto MapTagType(Context& context, const clang::TagType& type) | ||
| -> TypeExpr { | ||
| auto* tag_decl = type.getOriginalDecl(); | ||
| auto* tag_decl = type.getDecl(); |
There was a problem hiding this comment.
Now that this PR is ready for review, it includes a sufficiently new version of LLVM for this rename.
| llvm::Triple target_triple(options_.codegen_options.target); | ||
| std::string target_error; | ||
| const llvm::Target* target = llvm::TargetRegistry::lookupTarget( | ||
| llvm::Triple(options_.codegen_options.target), target_error); | ||
| const llvm::Target* target = | ||
| llvm::TargetRegistry::lookupTarget(target_triple, target_error); |
There was a problem hiding this comment.
Yep, this should be gone now.
4 participants
This also updates the patch file for compiler-rt as upstream has changed a bit. No functional change.