Merge pull request #3842 from cardstack/host-dep-upgrades

Host app dependency upgrades for vite

Author: ef4

package.json

@@ -41,13 +41,13 @@
       "style-loader@2.0.0": "patches/style-loader@2.0.0.patch",
       "ember-css-url@1.0.0": "patches/ember-css-url@1.0.0.patch",
       "ember-basic-dropdown@8.0.4": "patches/ember-basic-dropdown@8.0.4.patch",
-      "ember-source@5.4.1": "patches/ember-source@5.4.1.patch",
       "monaco-editor@0.52.2": "patches/monaco-editor@0.52.2.patch",
       "@embroider/compat": "patches/@embroider__compat.patch",
       "ember-eslint-parser": "patches/ember-eslint-parser.patch",
       "openai": "patches/openai.patch",
       "matrix-js-sdk@38.3.0": "patches/matrix-js-sdk@38.3.0.patch",
-      "@embroider/webpack": "patches/@embroider__webpack.patch"
+      "@embroider/webpack": "patches/@embroider__webpack.patch",
+      "ember-source": "patches/ember-source.patch"
     },
     "onlyBuiltDependencies": [
       "@percy/core",

packages/host/app/components/operator-mode/code-submode/playground/spec-search.gts

@@ -1,4 +1,5 @@
 import type Owner from '@ember/owner';
+import { next } from '@ember/runloop';
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 
@@ -59,6 +60,11 @@ interface CreateCardSignature {
 class CreateCard extends Component<CreateCardSignature> {
   constructor(owner: Owner, args: CreateCardSignature['Args']) {
     super(owner, args);
-    this.args.createNewCard();
+    // "next" here is a workaround. This code should be refactored to not mutate
+    // tracked state during rendering. I'm adding the workaround instead because
+    // I'm in the middle of trying to upgrade deps.
+    next(() => {
+      this.args.createNewCard();
+    });
   }
 }

packages/host/package.json

@@ -122,7 +122,7 @@
     "ember-concurrency": "catalog:",
     "ember-css-url": "^1.0.0",
     "ember-elsewhere": "^2.0.0",
-    "ember-exam": "^9.0.0",
+    "ember-exam": "^10.0.0",
     "ember-focus-trap": "^1.0.1",
     "ember-freestyle": "^0.20.0",
     "ember-keyboard": "^8.2.1",

packages/realm-server/tests/indexing-test.ts

@@ -622,9 +622,11 @@ module(basename(__filename), function () {
           new URL(`${testRealm}boom2`),
         );
         if (entry?.type === 'error') {
-          assert.strictEqual(
-            entry.error.errorDetail.message,
-            'Attempted to resolve a modifier in a strict mode template, but it was not in scope: did-insert',
+          assert.ok(
+            /Attempted to resolve a modifier in a strict mode template, but that value was not in scope: did-insert/.test(
+              entry.error.errorDetail.message,
+            ),
+            'error text is about did-insert not being in scope',
           );
           assert.deepEqual(entry.error.errorDetail.deps, [`${testRealm}boom2`]);
         } else {

patches/ember-source.patch

@@ -0,0 +1,15 @@
+diff --git a/dist/ember-template-compiler.js b/dist/ember-template-compiler.js
+index 01999af0c4c125af3c713318db7eb85fa492f72d..becb917a5b5fd7fd4883001210776ea34439c474 100644
+--- a/dist/ember-template-compiler.js
++++ b/dist/ember-template-compiler.js
+@@ -8288,9 +8288,7 @@ var define, require;
+             */
+             toSlice(expected) {
+               const chars = this.data.asString();
+-              return void 0 !== expected && chars !== expected &&
+-              // eslint-disable-next-line no-console
+-              console.warn(`unexpectedly found ${JSON.stringify(chars)} when slicing source, but expected ${JSON.stringify(expected)}`), new SourceSlice({
++              return new SourceSlice({
+                 loc: this,
+                 chars: expected || chars
+               });

patches/ember-source@5.4.1.patch

@@ -129,7 +129,7 @@ catalog:
   ember-modify-based-class-resource: ^1.1.0
   ember-qunit: ^8.0.1
   ember-resources: ^7.0.7
-  ember-source: ~5.4.1
+  ember-source: ~5.12.0
   ember-template-lint: ^7.8.1
   esbuild: ^0.24.0
   eslint: ^8.57.1