-
Notifications
You must be signed in to change notification settings - Fork 293
feat: agents mcp #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: agents mcp #643
Conversation
mattzcarey
commented
Nov 8, 2025
- loads from Github, caches chunks in KV for 1 day.
- uses stemming to do a fuzzy keyword match.
|
commit: |
Claude Code ReviewIssues Found1. Missing KV namespace binding configuration (site/agents-mcp/wrangler.jsonc:7-10) "kv_namespaces": [
{
"binding": "DOCS_KV"
// Missing: "id": "<namespace-id>"
}
]2. Global state mutation risk (site/agents-mcp/src/utils.ts:26-29) 3. Missing error handling for KV operations (site/agents-mcp/src/utils.ts:124-127) 4. No tests 5. Incomplete TODO (site/agents-mcp/src/index.ts:9) Minor/Style
|
threepointone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will review in detail later, this is exciting but I need to finish my slides haha
| inputSchema | ||
| }, | ||
| async ({ query, k }) => { | ||
| const searchEffect = Effect.gen(function* () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sneaking in effect huh
| "types": "wrangler types" | ||
| }, | ||
| "dependencies": { | ||
| "@cfworker/json-schema": "^4.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't be necessary if we land https://github.com/cloudflare/agents/pull/620/files#diff-0b2ee78feb201d3caa4914dcbf17821b7a21d6e5d0f708fc2eadcf7ee8f83c38R28
| }, | ||
| async ({ query, k }) => { | ||
| const searchEffect = Effect.gen(function* () { | ||
| console.log({ query, k }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stray log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd kinda like to have some logging on the queries are being asked. We need to instrument the server properly but I added this till then.