Skip to content

Commit 2410b82

Browse files
serdarozerrstephanme
authored andcommitted
fix: copilot reviews are fixed
1 parent 8d524f8 commit 2410b82

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

.github/scripts/alioss/run-int.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ repo_root="$(cd "${script_dir}/../../.." && pwd)"
1111

1212
export ACCESS_KEY_ID="${access_key_id}"
1313
export ACCESS_KEY_SECRET="${access_key_secret}"
14-
export ENDPOINT="oss-"${region}".aliyuncs.com"
14+
export ENDPOINT="oss-${region}.aliyuncs.com"
1515

1616
pushd "${script_dir}" > /dev/null
1717
source utils.sh

.github/scripts/alioss/teardown.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ pushd "${script_dir}"
2020
source utils.sh
2121
aliyun_configure
2222
if delete_bucket "${test_name}" ; then
23-
delete_bucket_name_file "${test_name}"
23+
delete_bucket_name_file "${test_name}"
2424
else
2525
exit 1
2626
fi

.github/scripts/alioss/utils.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function delete_bucket_name_file {
3333
function aliyun_configure {
3434
aliyun configure set --access-key-id "$ALI_ACCESS_KEY_ID" \
3535
--access-key-secret "$ALI_ACCESS_KEY_SECRET" \
36-
--region "$ALI_REGION"
36+
--region "$ALI_REGION"
3737
}
3838

3939
function bucket_exists {

alioss/README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ curl -X GET <signed url>
5050
## Running Tests
5151

5252
### Unit Tests
53+
Navigate to project's root folder. And run the following commands.
5354
```bash
5455
go install github.com/onsi/ginkgo/v2/ginkgo
5556
ginkgo --skip-package=integration --randomize-all --cover -v -r ./alioss/...
@@ -67,11 +68,11 @@ ginkgo --skip-package=integration --randomize-all --cover -v -r ./alioss/...
6768
1. go build -o ./alioss ./alioss && go test ./alioss/integration/...
6869

6970
- To run it from scratch; create a new bucket, run tests, delete the bucket
70-
1. Create a user in your ali account and add policy `AliyunOSSFullAccess` or restrict the users with more granular policies like `oss:CreateBucket, oss:DeleteBucket` etc.
71+
1. Create a user in your ali account and add policy `AliyunOSSFullAccess`, or restrict the users with more granular policies like `oss:CreateBucket`, `oss:DeleteBucket` etc.
7172
1. Create access key for the user.
7273
1. Export `AccessKeyId` with command `export access_key_id=<AccessKeyId>`.
73-
1. Export `AccessKeySecret` with command `export access_key_secret=<AccessKeyId>`.
74+
1. Export `AccessKeySecret` with command `export access_key_secret=<AccessKeySecret>`.
7475
1. Navigate to project's root folder.
75-
1. Run environment setup script to create container `/.github/scripts/alioss/setup.sh`.
76-
1. Run tests `/.github/scripts/alioss/run-int.sh`.
77-
1. Run environment teardown script to delete test resources `/.github/scripts/alioss/teardown.sh`.
76+
1. Run environment setup script to create bucket `./.github/scripts/alioss/setup.sh`.
77+
1. Run tests `./.github/scripts/alioss/run-int.sh`.
78+
1. Run environment teardown script to delete test resources `./.github/scripts/alioss/teardown.sh`.

0 commit comments

Comments
 (0)