One Main #13
Open
One Main #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Factory function created for object creation - Commands migrated to strategy module - Common interface is created - Each client implemeted common interface alioss, azurebs, gcs, s3 - Test are refactored based on common interface - Dav client still not integrated into main since it has different implementation
serdarozerr
force-pushed
the
feature/one-main
branch
from
925681d to
64982c8
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
- sign action converted to lower to handle variations - Nonflagargs condition fixed to be 1, with new commands it can be only command name like; list, ensure-storage-exists
beyhan
requested review from
a-hassanin,
aramprice,
beyhan and
rkoster
and removed request for
Copilot
beyhan
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
- dav/app used as proxy to be compatible with existing storager interface - dav/main deleted - config reader created for dav - defer close added to main for config file
- factory refactored to write tests easly.
- ExecuteCommand refactored to return errors. - Logging function moved to main
- command(put,delete...) from nonFlagArgs extracted and only arguments for that command being send into the ExecuteCommand function
beyhan
reviewed
Dec 5, 2025
Member
beyhan
left a comment
beyhan
left a comment
There was a problem hiding this comment.
We discussed this PR during yesterday's FI WG meeting. We think it makes sense to try integrating one of the storage provider options (like Azure or S3) into Director, Agent, and BOSH CLI as a POC, with the goal of verifying that this approach will work for the BOSH components.
johha
reviewed
Dec 5, 2025
|
|
||
| ## Configuration | ||
| The command line tool expects a JSON configuration file. Run `storage-cli-gcs --help` for details. | ||
| The GCS client requires a JSON configuration file. |
There was a problem hiding this comment.
Would be nice to have a configuration example here as well similar to the others. But as this not present in bosh-gcscli this can be added later.
Contributor
Author
There was a problem hiding this comment.
Sure, once i have an example config will add.
github-project-automation
bot
moved this from Pending Review | Discussion
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Object creation and command handling were duplicated across clients. Each backend (alioss, azurebs, gcs, s3) had its own entrypoint and build workflow, creating extra maintenance overhead.
Solution
This update introduces a unified architecture to reduce duplication and streamline maintenance across all storage clients. A factory function now handles object creation, and command logic has been moved into a dedicated strategy module. A common interface was added and implemented by alioss, azurebs, gcs, and s3, ensuring consistent behavior across clients. Tests were refactored to target this shared interface. With the latest changes, the DAV client has also been integrated into the new main: its app package is used as a proxy to conform to the shared interface, its standalone main was removed.