fix: avoid trailing Z when converting RFC3339 timestamps in UTC for postgres #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaime Silvela <[email protected]>
jsilvela
changed the title
jsilvela
commented
Oct 29, 2025
| // to avoid problems when used for recovery_target_time | ||
| func ConvertToPostgresFormat(timestamp string) string { | ||
| formatWithoutZ := func(t time.Time) string { | ||
| formatted := t.Format("2006-01-02 15:04:05.000000Z07:00") |
Author
There was a problem hiding this comment.
Here, questions. In the ParseTargetTime function in pkg/types/time.go , we make use of pq.ParseTimestamp().
Why not use pq.FormatTimestamp() here, regardless of input formats?
Moreover, why not validate the input in this function? We validated RFC3339 and RFC3339Micro, but standalone, this function, given "foo", will assume it's a valid timestamp and just return it.
Author
|
There is an E2E test exercising the conversion function: cloudnative-pg/cloudnative-pg#8981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167
Avoid the trailing Z in RFC3339 / ISO 8601 in UTC zone, which does not play as a recovery target time.