fix: PR feedback

Author: phortx

mocks/obsidian.ts

@@ -47,7 +47,7 @@ class DataAdapter {
   }
 
   async writeBinary(path: string, content: ArrayBuffer, option?: DataWriteOptions): Promise<void> {
-    this._writeBinary = [path, content]
+    this._writeBinary = [path, content];
   }
 
   async remove(path: string): Promise<void> {
@@ -158,7 +158,7 @@ export class FileStats {
 
 export class TFile {
   path = "somefile.md";
-  basename: string = "somefile";
+  basename = "somefile";
   stat: FileStats = new FileStats();
 }
 
@@ -175,7 +175,14 @@ export class SearchResult {
   matches: [number, number][] = [];
 }
 
-export function prepareSimpleSearch(
+// Mock configuration that tests can control
+// Tests can set this to override the default behavior
+export const _prepareSimpleSearchMock = {
+  behavior: null as ((query: string) => (text: string) => null | SearchResult) | null,
+};
+
+// Default implementation (can be overridden by tests)
+function defaultPrepareSimpleSearch(
   query: string
 ): (value: string) => null | SearchResult {
   return (text: string) => {
@@ -199,3 +206,12 @@ export function prepareSimpleSearch(
     return result;
   };
 }
+
+export function prepareSimpleSearch(
+  query: string
+): (value: string) => null | SearchResult {
+  if (_prepareSimpleSearchMock.behavior) {
+    return _prepareSimpleSearchMock.behavior(query);
+  }
+  return defaultPrepareSimpleSearch(query);
+}

src/requestHandler.ts

@@ -1013,13 +1013,13 @@ export default class RequestHandler {
     for (const file of this.app.vault.getMarkdownFiles()) {
       const cachedContents = await this.app.vault.cachedRead(file);
 
-      // Add the headline to the search text to include it in the search.
+      // Add the filename to the search text to include it in the search.
       const filenamePrefix = file.basename + "\n\n";
       const result = search(filenamePrefix + cachedContents);
 
-      // We added the headline to the search text with 2 line breaks.
+      // We added the filename to the search text with 2 newline characters.
       // That causes the start and end position numbers to be wrong with an offset
-      // of the char length of the headline line breaks.
+      // of the char length of the filename newline characters.
       // This is fixed by subtracting the positionOffset from the start and end position.
       const positionOffset = filenamePrefix.length;