Fix space typings
#13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
'rgb' | 'hsl' | ... | stringeffectively collapses to juststringbecausestringis a supertype of all string literals. This causes TypeScript to lose the ability to distinguish specific values like'rgb'.To preserve those literal types while still allowing arbitrary strings, we can use the “intersection hack” (
{} & string) — also known as an opaque string type. This allowsspaceto be either one of the known literals ('rgb','hsl', etc.) or any other string, while still enabling TypeScript to narrow correctly.See this link for how this change resolves the issue: https://www.typescriptlang.org/play/?#code/C4TwDgpgBAKhDOwoF4oHIBOBzARmqAPugBbwA2+RaxA7noegMYC2IA1pemQIb1VmNinNAHs2PPujEChDRBgCWAOywBuAFAB6TVF0A9APzr1oSLATAATCnTZJ1csNr2W7YRPeDh03t-FeGAAoAbwBfKAAyKHllLABKDW1dKEMgA