Skip to content

UI: Show harness img if user selects #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ugtthis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UI: Show harness img if user selects #260

ugtthis wants to merge 3 commits into from

Conversation

@ugtthis
Copy link
Contributor

@ugtthis ugtthis commented Dec 1, 2025 •
edited
Loading

  • builds off of the layout fixes in PR Fix "In the Box" layout #258
  • shows harness img depending on what user chooses w/harness dropdown
  • uses URL param as source of truth, matching HarnessSelector behavior
  • if 3 items -> shows it in a row unless mobile
  • if 4 items -> always shows 2x2 preventing widow item unless mobile
  • items always stack IF mobile

UI preview:

ui-preview-1.mp4

@ugtthis ugtthis marked this pull request as draft December 1, 2025 19:51
@ugtthis ugtthis marked this pull request as ready for review December 1, 2025 20:05
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

deployed preview: https://comma-web--pr260-s3b01wc9.web.app

Welcome! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ugtthis