Enable timeout support for each service handler #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mausam Yadav <[email protected]>
R4R3D1FF
force-pushed
the
service-handler-timeout
branch
from
decd22f to
b865468
Compare
emcfarlane
reviewed
Oct 6, 2025
Contributor
emcfarlane
left a comment
emcfarlane
left a comment
There was a problem hiding this comment.
Thanks for the PR! I will bring up with the other maintainers to discuss the usability side. For the PR we need to complete testing and documentation.
Co-authored-by: Edward McFarlane <[email protected]> Signed-off-by: R4R3D1FF <[email protected]>
R4R3D1FF
force-pushed
the
service-handler-timeout
branch
2 times, most recently
from
acb843f to
91b7827
Compare
Added documentation comments in the new exported options Signed-off-by: R4R3D1FF <[email protected]> Signed-off-by: Mausam Yadav <[email protected]>
R4R3D1FF
force-pushed
the
service-handler-timeout
branch
from
91b7827 to
cc784c6
Compare
Author
Alright, do you have any ideas as to how I can test this? I think it could be done via a client that intentionally stalls the message sent to or received from the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option for read and write timeout in the handler options, that is passed to the handler config and then to the spec. Finally, ServeHTTP function of the handler reads the timeout values from the spec and enforces them using ResponseController.
This prevents slow or malicious clients from using up resources as that specific stream for the HTTP2 connection can be closed.
Deals with the following issue
#879