Reverse order of ReplaceEvent

Author: Jon Staab

zooid/events.go

@@ -295,25 +295,27 @@ func (events *EventStore) SaveEvent(evt nostr.Event) error {
 }
 
 func (events *EventStore) ReplaceEvent(evt nostr.Event) error {
+	// First, save the new event, then find all matching events and delete every one
+	// except the newest one. This is sort of stupid, but we had missing metadata
+	if err := events.SaveEvent(evt); err != nil && err != eventstore.ErrDupEvent {
+		return fmt.Errorf("failed to save: %w", err)
+	}
+
 	filter := nostr.Filter{Kinds: []nostr.Kind{evt.Kind}, Authors: []nostr.PubKey{evt.PubKey}}
+
 	if evt.Kind.IsAddressable() {
 		filter.Tags = nostr.TagMap{"d": []string{evt.Tags.GetD()}}
 	}
 
-	shouldStore := true
-	for previous := range events.QueryEvents(filter, 1) {
-		if previous.CreatedAt <= evt.CreatedAt {
-			if err := events.DeleteEvent(previous.ID); err != nil {
-				return fmt.Errorf("failed to delete event for replacing: %w", err)
-			}
-		} else {
-			shouldStore = false
+	isFirstEvent := true
+	for previous := range events.QueryEvents(filter, 0) {
+		if isFirstEvent {
+			isFirstEvent = false
+			continue
 		}
-	}
 
-	if shouldStore {
-		if err := events.SaveEvent(evt); err != nil && err != eventstore.ErrDupEvent {
-			return fmt.Errorf("failed to save: %w", err)
+		if err := events.DeleteEvent(previous.ID); err != nil {
+			return fmt.Errorf("failed to delete event for replacing: %w", err)
 		}
 	}