Fixed several technically failing tests.

Also fixed a bug that caused mistaken use of RevTrees for EncryptedVersionVectorOption.

Author: jianminzhao

C/tests/c4ObserverTest.cc

@@ -40,12 +40,6 @@ class C4ObserverTest : public C4Test {
         }
     }
 
-#if SkipVersionVectorTest
-    static constexpr int numberOfOptions = 1;
-#else
-    static constexpr int numberOfOptions = 2;  // rev-tree, vector; no need to test encryption
-#endif
-
     ~C4ObserverTest() {
         c4docobs_free(docObserver);
         c4dbobs_free(dbObserver);

C/tests/c4Test.cc

@@ -132,10 +132,7 @@ string C4Test::sReplicatorFixturesDir = "Replicator/tests/data/";
 
 
 C4Test::C4Test(int num) : _storage(kC4SQLiteStorageEngine) {  // NOLINT(cppcoreguidelines-pro-type-member-init)
-    constexpr static TestOptions numToTestOption[] = {
-        VersionVectorOption,
-        EncryptedVersionVectorOption
-    };
+    constexpr static TestOptions numToTestOption[] = {VersionVectorOption, EncryptedVersionVectorOption};
     static_assert(sizeof(numToTestOption) / sizeof(TestOptions) >= numberOfOptions);
     TestOptions testOption = numToTestOption[num];
 
@@ -183,13 +180,14 @@ C4Test::C4Test(int num) : _storage(kC4SQLiteStorageEngine) {  // NOLINT(cppcoreg
     objectCount = c4_getObjectCount();
 
     _dbConfig = {slice(TempDir()), kC4DB_Create};
-    if ( testOption == VersionVectorOption ) {
+    if ( testOption == VersionVectorOption || testOption == EncryptedVersionVectorOption ) {
         _dbConfig.flags |= kC4DB_VersionVectors | kC4DB_FakeVectorClock;
         kRev1ID = kRevID = kRev1ID_Alt = C4STR("1@*");
         kRev2ID                        = C4STR("2@*");
         kRev3ID                        = C4STR("3@*");
         kRev4ID                        = C4STR("4@*");
     } else {
+        Assert(false, "Unsupported option");
         kRev1ID = kRevID = C4STR("1-abcd");
         kRev1ID_Alt      = C4STR("1-dcba");
         kRev2ID          = C4STR("2-c001d00d");
@@ -327,6 +325,24 @@ void C4Test::upgradeToVersionVectors(bool fakeClock) {
     syncDBConfig();
 }
 
+void C4Test::resetDBToRevTrees(C4Database*& database) {
+    C4DatabaseConfig2 config = dbConfig();
+    Assert((config.flags & kC4DB_VersionVectors), "db already uses Rev Trees");
+
+    alloc_slice name(c4db_getName(database));
+    REQUIRE(c4db_close(database, WITH_ERROR()));
+    c4db_release(database);
+    database = nullptr;
+    C4Error error{};
+    if ( !c4db_deleteNamed(name, config.parentDirectory, ERROR_INFO(&error)) ) Require(error.code == 0);
+
+    C4Log("---- Reopening '%.*s' with version vectors ---", FMTSLICE(name));
+    config.flags &= ~kC4DB_VersionVectors;
+    config.flags &= ~kC4DB_FakeVectorClock;
+    database = c4db_openNamed(name, &config, ERROR_INFO());
+    REQUIRE(database);
+}
+
 /*static*/ C4Collection* C4Test::createCollection(C4Database* db, C4CollectionSpec spec) {
     auto coll = c4db_createCollection(db, spec, ERROR_INFO());
     Require(coll);

C/tests/c4Test.hh

@@ -176,7 +176,7 @@ class C4Test {
     static constexpr int         numberOfOptions               = 2;  //  See nameOfOption
     static constexpr const char* nameOfOption[numberOfOptions] = {"VersionVector", "EncryptedVersionVector"};
 #else
-    static constexpr int         numberOfOptions = 1;  // rev-tree
+    static constexpr int         numberOfOptions               = 1;  // rev-tree
     static constexpr const char* nameOfOption[numberOfOptions] = {"VersionVector"};
 #endif
 
@@ -231,6 +231,7 @@ class C4Test {
     /// Closes `db`, adds `kC4DB_VersionVectors` to config, and reopens.
     void upgradeToVersionVectors(bool fakeClock = false);
     void upgradeToVersionVectors(C4Database*&, bool fakeClock = false);
+    void resetDBToRevTrees(C4Database*&);
 
     static C4Collection* createCollection(C4Database* db, C4CollectionSpec spec);
     static C4Collection* getCollection(C4Database* db, C4CollectionSpec spec, bool mustExist = true);

Replicator/tests/ReplicatorAPITest.cc

@@ -22,6 +22,8 @@
 #include "c4Internal.hh"
 #include "fleece/Fleece.hh"
 #include "SequenceSet.hh"
+#include "SourceID.hh"
+#include "VersionVector.hh"
 
 using namespace fleece;
 using namespace std;
@@ -263,11 +265,14 @@ TEST_CASE_METHOD(ReplicatorAPITest, "API Loopback Push & Pull Deletion", "[C][Pu
     c4::ref<C4Document> doc         = c4coll_getDoc(defaultColl, "doc"_sl, true, kDocGetAll, nullptr);
     REQUIRE(doc);
 
-    CHECK(doc->revID == kRev2ID);
+    alloc_slice dbSourceID = c4db_getSourceID(db);
+    auto        pair       = split2(string_view(slice(kRev2ID)), string_view("@"));
+    REQUIRE(!pair.second.empty());
+    string rev2ID = string(pair.first) + "@" + dbSourceID.asString();
+
+    CHECK(slice(doc->revID) == slice(rev2ID));
     CHECK((doc->flags & kDocDeleted) != 0);
     CHECK((doc->selectedRev.flags & kRevDeleted) != 0);
-    REQUIRE(c4doc_selectParentRevision(doc));
-    CHECK(doc->selectedRev.revID == kRevID);
 }
 
 TEST_CASE_METHOD(ReplicatorAPITest, "Per Collection Context Documents Ended", "[Pull][Sync]") {

Replicator/tests/ReplicatorVVUpgradeTest.cc

@@ -59,6 +59,15 @@ class ReplicatorVVUpgradeTest : public ReplicatorLoopbackTest {
         upgradeToVersionVectors(db2, fakeClock);
         _collDB2 = createCollection(db2, _collSpec);
     }
+
+    /// Reopens both databases, enabling version vectors in both.
+    void resetDBsToRevTrees() {
+        resetDBToRevTrees(db);
+        _collDB1 = createCollection(db, _collSpec);
+        resetDBToRevTrees(db2);
+        _collDB2 = createCollection(db2, _collSpec);
+        syncDBConfig();
+    }
 };
 
 TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Push After VV Upgrade", "[Push][Upgrade]") {
@@ -69,6 +78,7 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Push After VV Upgrade", "[Push][Upgra
 
     auto serverOpts = Replicator::Options::passive(_collSpec);
 
+    resetDBsToRevTrees();
     importJSONLines(sFixturesDir + "names_100.json", _collDB1);
     _expectedDocumentCount = 100;
     Log("-------- First Replication --------");
@@ -94,6 +104,7 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Pull After VV Upgrade", "[Pull][Upgra
     //- db updates two of the docs it pushed, and creates a new one.
     //- db pushes to db2 again.
 
+    resetDBsToRevTrees();
     importJSONLines(sFixturesDir + "names_100.json", _collDB1);
     _expectedDocumentCount = 100;
     Log("-------- First Replication --------");
@@ -112,6 +123,7 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Pull After VV Upgrade", "[Pull][Upgra
 }
 
 TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Push and Pull New Docs After VV Upgrade", "[Push][Pull][Upgrade]") {
+    resetDBsToRevTrees();
     populateAndSync();
 
     Log("-------- Create a doc in each db --------");
@@ -127,6 +139,7 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Push and Pull New Docs After VV Upgra
 }
 
 TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Push and Pull Existing Docs After VV Upgrade", "[Push][Pull][Upgrade]") {
+    resetDBsToRevTrees();
     populateAndSync();
 
     Log("-------- Update existing doc in each db --------");
@@ -188,6 +201,7 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Resolve Rev-Tree Conflicts After VV U
         default:
             throw logic_error("unreachable");
     }
+    resetDBsToRevTrees();
 
     DYNAMIC_SECTION("" << sectionName) {
         createFleeceRev(_collDB1, docName, "1-1111"_sl, "{}"_sl);
@@ -235,6 +249,8 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Resolve Mixed Conflicts After VV Upgr
     const alloc_slice kDoc1Rev2B  = makeRealishVector("@BobBobBobBobBobBobBobA");
     const alloc_slice kDoc1RevRTE = makeRealishVector("@Revision+Tree+Encoding");
 
+    resetDBsToRevTrees();
+
     createFleeceRev(_collDB1, docName, "1-1111"_sl, "{}"_sl);
 
     slice winner, loser, body, resultingRevID;
@@ -364,6 +380,9 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Resolve Mixed Conflicts After VV Upgr
 
 TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Resolve Conflicts After VV Upgrade", "[Conflicts][Upgrade][Pull]") {
     const auto docName = "test"_sl;
+
+    resetDBsToRevTrees();
+
     upgrade();
     syncDBConfig();
 
@@ -420,4 +439,4 @@ TEST_CASE_METHOD(ReplicatorVVUpgradeTest, "Resolve Conflicts After VV Upgrade",
     } else {
         CHECK(slice(finalDoc->selectedRev.revID).findByte('*'));
     }
-}
+}