MB-49624 Add all bucket config keys modifiable via UI in ...

... bucket_cfg_changed event log

It seems like the UI now sends only keys that are changed in the bucket
edit section. Retrieve all the relevant keys that can be changed via the
UI and add their "new value" in the new_settings section.

Also fixed a case where I added an event_log at the end of case
expression which could have masked any errors generated by
ns_bucket:update_props/2. Sad story.

Change-Id: I6b2ce4008ebaff743754365969972034da6baf5b
Reviewed-on: https://review.couchbase.org/c/ns_server/+/166019
Well-Formed: Build Bot <[email protected]>
Tested-by: Build Bot <[email protected]>
Tested-by: Hareen Kancharla <[email protected]>
Reviewed-by: Steve Watanabe <[email protected]>

Author: hareen-kancharla

src/ns_bucket.erl

@@ -995,16 +995,26 @@ update_bucket_props(Type, StorageMode, BucketName, Props) ->
             DisplayBucketType = ns_bucket:display_type(Type, StorageMode),
 
             %% Update the bucket properties.
-            update_bucket_props(BucketName, Props),
-
-            event_log:add_log(bucket_cfg_changed,
-                              [{bucket, list_to_binary(BucketName)},
-                               {bucket_uuid, uuid(BucketName, direct)},
-                               {type, DisplayBucketType},
-                               {old_settings,
-                                {struct, build_bucket_props_json(PrevProps)}},
-                               {new_settings,
-                                {struct, build_bucket_props_json(Props)}}]);
+            RV = update_bucket_props(BucketName, Props),
+
+            case RV of
+                ok ->
+                    {ok, NewBucketConfig} = ns_bucket:get_bucket(BucketName),
+                    NewProps = extract_bucket_props(NewBucketConfig),
+                    event_log:add_log(bucket_cfg_changed,
+                                      [{bucket, list_to_binary(BucketName)},
+                                       {bucket_uuid, uuid(BucketName, direct)},
+                                       {type, DisplayBucketType},
+                                       {old_settings,
+                                        {struct, build_bucket_props_json(
+                                                   PrevProps)}},
+                                       {new_settings,
+                                        {struct, build_bucket_props_json(
+                                                   NewProps)}}]),
+                    ok;
+                _ ->
+                    RV
+            end;
         false ->
             {exit, {not_found, BucketName}, []}
     end.