Skip to content

Commit 5e9c45e

Browse files
chore: reify, use opt chaining where relevant (#1427)
<!-- For Coveo Employees only. Fill this section. CDX-764 --> ## Proposed changes <!-- Explains what are you changing in the code and provide links to relevant issues. This doesn't need to be over-technical, a good summary of the issues with good explanations of the decisions should be enough. --> ## Breaking changes <!-- Remove this section if the PR does not include any breaking change If your changes includes some breaking changes in the code, thoroughly explains: - What are the breaking changes programmatically speaking. - What is the impact on the end-user (e.g. user cannot do X anymore). - What motivates those changes. --> ## Testing - [ ] Unit Tests: <!-- Did you write unit tests for your feature? If not, explains why? --> - [ ] Functionnal Tests: <!-- Did you write functionnal tests for your feature? If not, explains why? --> - [ ] Manual Tests: <!-- How did you test your changeset? -->
1 parent 70db6c1 commit 5e9c45e

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

packages/cli-e2e/setup/utils/verdaccio.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const verdaccioedPackages = [
2323
'@coveo/cli-commons-dev',
2424
'@coveo/cli-commons',
2525
'@coveo/cli',
26+
'@coveo/cli-plugin-source',
2627
];
2728

2829
export async function publishPackages() {

packages/cli-e2e/verdaccio/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ uplinks:
2222
packages:
2323
# All templates packages and the search-token-server are published and fetched from Verdaccio
2424
# No uplink is allowed, so if it ain't published on Verdaccio, it'll fail.
25-
'@coveo/@(angular|create-headless-vue|cra-template|search-token-server|create-atomic|search-token-lambda|cli-commons-dev|cli-commons|cli|atomic-component-health-check)':
25+
'@coveo/@(angular|create-headless-vue|cra-template|search-token-server|create-atomic|search-token-lambda|cli-commons-dev|cli-plugin-source|cli-commons|cli|atomic-component-health-check)':
2626
access: $all
2727
publish: $all
2828
unpublish: $all

utils/release/reify.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ function buildDependencyGraph(rootNode) {
4141
: node.edgesOut;
4242
const workspaces = edgesOut.filter(
4343
(edge) =>
44-
edge.to.package.name && rootNode.workspaces?.has(edge.to.package.name)
44+
edge?.to?.package?.name &&
45+
rootNode.workspaces?.has(edge.to.package.name)
4546
);
4647
return workspaces.map((edge) =>
4748
edge.to instanceof Arborist.Link ? edge.to.target : edge.to

0 commit comments

Comments
 (0)