Implement default s3 path when only bucket provided for etcd snapshots (#37)

* Implement default s3 path when only bucket provided for etcd snapshots

* Test default snapshot path and explicit snapshot path

Author: brooksmtownsend

pkg/snapshot/snapshot.go

@@ -70,10 +70,13 @@ func ParseSnapshotBackupURL(s string) (*URL, error) {
 			Path: filepath.Join(u.Host, u.Path),
 		}, nil
 	case "s3":
+		if u.Path == "" {
+			u.Path = "etcd.snapshot"
+		}
 		return &URL{
 			Type:   S3Type,
 			Bucket: u.Host,
-			Path:   u.Path,
+			Path:   strings.TrimPrefix(u.Path, "/"),
 		}, nil
 	case "http", "https":
 		if strings.Contains(u.Host, "digitaloceanspaces") {

pkg/snapshot/snapshot_test.go

@@ -43,7 +43,17 @@ func TestParseSnapshotBackupURL(t *testing.T) {
 		{
 			name:     "s3",
 			url:      "s3://abc",
-			expected: &URL{Type: S3Type, Bucket: "abc"},
+			expected: &URL{Type: S3Type, Bucket: "abc", Path: "etcd.snapshot"},
+		},
+		{
+			name:     "s3",
+			url:      "s3://abc/snapshot.gz",
+			expected: &URL{Type: S3Type, Bucket: "abc", Path: "snapshot.gz"},
+		},
+		{
+			name:     "s3",
+			url:      "s3://abc/backupdir/snapshot.gz",
+			expected: &URL{Type: S3Type, Bucket: "abc", Path: "backupdir/snapshot.gz"},
 		},
 		{
 			name:     "spaces",