Skip to content

Commit c7b514e

Browse files
- FIX: Fixed some issues with server info enums.
- CHG: Preparation for bugfix release.
1 parent f324510 commit c7b514e

File tree

5 files changed

+44
-6
lines changed

5 files changed

+44
-6
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ plugins {
44
}
55

66
group 'uk.ac.hutton.ics'
7-
version '1.0.1'
7+
version '1.0.2'
88

99
sourceCompatibility = 11
1010

src/main/java/uk/ac/hutton/ics/brapi/resource/base/BaseResult.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ public class BaseResult<T>
99
private Metadata metadata = new Metadata();
1010
private T result;
1111

12+
public BaseResult()
13+
{
14+
}
15+
1216
public BaseResult(T result, int currentPage, int pageSize, long totalCount)
1317
{
1418
this.result = result;

src/main/java/uk/ac/hutton/ics/brapi/resource/base/BrapiCall.java

Lines changed: 34 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public BrapiCall addVersion(Version version)
3939

4040
public boolean hasDataType(DataType datatype)
4141
{
42-
return dataTypes.contains(datatype.name());
42+
return dataTypes.contains(datatype.getType());
4343
}
4444

4545
public boolean hasMethod(Method method)
@@ -49,7 +49,7 @@ public boolean hasMethod(Method method)
4949

5050
public boolean hasVersion(Version version)
5151
{
52-
return versions.contains(version.name());
52+
return versions.contains(version.getNumber());
5353
}
5454

5555
public String getService()
@@ -65,7 +65,7 @@ public BrapiCall setService(String service)
6565

6666
public List<DataType> getDataTypes()
6767
{
68-
return dataTypes.stream().map(DataType::valueOf).collect(Collectors.toList());
68+
return dataTypes.stream().map(DataType::getFromString).collect(Collectors.toList());
6969
}
7070

7171
public List<Method> getMethods()
@@ -75,7 +75,7 @@ public List<Method> getMethods()
7575

7676
public List<Version> getVersions()
7777
{
78-
return versions.stream().map(Version::valueOf).collect(Collectors.toList());
78+
return versions.stream().map(Version::getFromString).collect(Collectors.toList());
7979
}
8080

8181
public enum DataType
@@ -90,6 +90,21 @@ public enum DataType
9090
{
9191
this.type = type;
9292
}
93+
94+
public String getType() {
95+
return type;
96+
}
97+
98+
public static DataType getFromString(String type)
99+
{
100+
for (DataType dt : DataType.values())
101+
{
102+
if (Objects.equals(dt.type, type))
103+
return dt;
104+
}
105+
106+
return null;
107+
}
93108
}
94109

95110
public enum Method
@@ -114,5 +129,20 @@ public enum Version
114129
{
115130
this.number = number;
116131
}
132+
133+
public String getNumber() {
134+
return number;
135+
}
136+
137+
public static Version getFromString(String version)
138+
{
139+
for (Version v : Version.values())
140+
{
141+
if (Objects.equals(v.number, version))
142+
return v;
143+
}
144+
145+
return null;
146+
}
117147
}
118148
}

src/main/java/uk/ac/hutton/ics/brapi/resource/base/TokenPagination.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public TokenPagination(int pageSize, String currentPageToken, long totalCount, i
2121
this.totalCount = totalCount;
2222
this.totalPages = (int) Math.ceil(totalCount / (float) desiredPageSize);
2323

24-
// If we can, generate valeus for prevPageToken and nextPageToken
24+
// If we can, generate values for prevPageToken and nextPageToken
2525
int currentPage = Integer.parseInt(currentPageToken);
2626
if (currentPage >= 1)
2727
prevPageToken = String.valueOf(currentPage - 1);

src/main/java/uk/ac/hutton/ics/brapi/resource/core/serverinfo/ServerInfo.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ public class ServerInfo
1515
private String serverDescription;
1616
private String serverName;
1717

18+
public ServerInfo()
19+
{
20+
}
21+
1822
public List<BrapiCall> getCalls()
1923
{
2024
return calls;

0 commit comments

Comments
 (0)