Skip to content

feat: auth google onetap#3928

Merged
capJavert merged 2 commits into
mainfrom
auth-google-onetap
Jun 5, 2026
Merged

feat: auth google onetap#3928
capJavert merged 2 commits into
mainfrom
auth-google-onetap

Conversation

@capJavert
Copy link
Copy Markdown
Contributor

No description provided.

@capJavert capJavert requested a review from rebelchris June 5, 2026 11:30
@capJavert capJavert self-assigned this Jun 5, 2026
Comment thread src/betterAuth.ts
body?.timezone ??
oauthState?.timezone ??
// used primarily in one-tap flow
hookCtx?.request?.headers?.get('x-timezone'),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not pass in body from onetap payload

@pulumi
Copy link
Copy Markdown

pulumi Bot commented Jun 5, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at 84ec66b) was successful.

✨ Neo Code Review

Routine deployment of a new application image that adds Google One Tap authentication support and a fallback `x-timezone` header for timezone capture during sign-up. ✅ Low Risk — no stateful infrastructure changes, no security group modifications, and the new plugin is opt-in based on an existing env var.

This is a routine application deployment rolling out a new image (1f573c8126535464) that introduces Google One Tap sign-in support and timezone capture via x-timezone header during the one-tap auth flow.

The migration Jobs (db and ClickHouse) are being cycled to the new commit hash, as expected with each release. The oneTap plugin is conditionally activated only when GOOGLE_CLIENT_ID is set in the environment, so activation in prod depends on that env var being present.

🔵 Info — The x-timezone header fallback is applied specifically to the one-tap sign-up path (lowest priority after body.timezone and oauthState.timezone), so existing sign-up flows are unaffected.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-yearly-best-post-archives-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-highlights-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-materialized-views-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-1f573c81               kubernetes:batch/v1:Job        delete
~   vpc-native-clean-zombie-opportunities-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-post-lifecycle-state-clickhouse-cron            kubernetes:batch/v1:CronJob    update
~   vpc-native-squad-posts-analytics-refresh-cron              kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-26535464                       kubernetes:batch/v1:Job        create
~   vpc-native-clean-stale-user-transactions-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-weekly-quests-cron                       kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-temporal-deployment                             kubernetes:apps/v1:Deployment  update
~   vpc-native-post-analytics-history-day-clickhouse-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-daily-quests-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
-   vpc-native-api-db-migration-1f573c81                       kubernetes:batch/v1:Job        delete
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-old-notifications-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-channel-highlights-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-clickhouse-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                              kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                            kubernetes:batch/v1:CronJob    update
... and 13 other changes

@capJavert capJavert enabled auto-merge (squash) June 5, 2026 12:05
@capJavert capJavert merged commit 6f8d7c9 into main Jun 5, 2026
9 checks passed
@capJavert capJavert deleted the auth-google-onetap branch June 5, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants