Skip to content

actual relayer (msg.sender) not asserted, behaving currently as a fee_recipient #2

@datgrog

Description

@datgrog

Right now Dach's Dai or Chai actions does not

require(relayer == msg.sender, "invalid relayer");

I could understand useful scenario such as a backend relaying meta-tx concurrently from differents EOAs while collecting fee on a specific address. However such implicit behaviour looks kind of "dangerous", given that its implicit. So right now, relayer parameter behave as a fee_recipient and if not asserted then a backend's relayer's EOA could be potentially emptied.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions