fix(storage): head requests not cached (#657)

stepbrobd · darkweak · web-flow · commit b2a08bf1141e · 2025-08-12T11:29:55.000+02:00
Co-authored-by: darkweak &lt;darkweak@protonmail.com&gt;
diff --git a/pkg/middleware/middleware.go b/pkg/middleware/middleware.go
@@ -350,7 +350,7 @@ func (s *SouinBaseHandler) Store(
 		}
 		res.Header.Set(rfc.StoredLengthHeader, res.Header.Get("Content-Length"))
 		response, err := httputil.DumpResponse(&res, true)
-		if err == nil && (bLen > 0 || canStatusCodeEmptyContent(statusCode) || s.hasAllowedAdditionalStatusCodesToCache(statusCode)) {
+		if err == nil && (bLen > 0 || rq.Method == http.MethodHead || canStatusCodeEmptyContent(statusCode) || s.hasAllowedAdditionalStatusCodesToCache(statusCode)) {
 			variedHeaders, isVaryStar := rfc.VariedHeaderAllCommaSepValues(res.Header)
 			if isVaryStar {
 				// "Implies that the response is uncacheable"

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ func (s *SouinBaseHandler) Store(`
`350`	`350`	`}`
`351`	`351`	`res.Header.Set(rfc.StoredLengthHeader, res.Header.Get("Content-Length"))`
`352`	`352`	`response, err := httputil.DumpResponse(&res, true)`
`353`		`- if err == nil && (bLen > 0 \|\| canStatusCodeEmptyContent(statusCode) \|\| s.hasAllowedAdditionalStatusCodesToCache(statusCode)) {`
	`353`	`+ if err == nil && (bLen > 0 \|\| rq.Method == http.MethodHead \|\| canStatusCodeEmptyContent(statusCode) \|\| s.hasAllowedAdditionalStatusCodesToCache(statusCode)) {`
`354`	`354`	`variedHeaders, isVaryStar := rfc.VariedHeaderAllCommaSepValues(res.Header)`
`355`	`355`	`if isVaryStar {`
`356`	`356`	`// "Implies that the response is uncacheable"`