refactor!: remove permission hook and AuthManager from core path

Author: sunng87

datafusion-postgres-cli/src/main.rs

@@ -198,8 +198,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let session_config = SessionConfig::new().with_information_schema(true);
     let session_context = SessionContext::new_with_config(session_config);
-    let auth_manager = Arc::new(AuthManager::new());
 
+    let auth_manager = Arc::new(AuthManager::new());
     setup_session_context(&session_context, &opts, Arc::clone(&auth_manager)).await?;
 
     let server_options = ServerOptions::new()
@@ -208,7 +208,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .with_tls_cert_path(opts.tls_cert)
         .with_tls_key_path(opts.tls_key);
 
-    serve(Arc::new(session_context), &server_options, auth_manager)
+    serve(Arc::new(session_context), &server_options)
         .await
         .map_err(|e| format!("Failed to run server: {e}"))?;
 

datafusion-postgres/src/handlers.rs

@@ -22,9 +22,7 @@ use pgwire::api::{ClientInfo, ErrorHandler, PgWireServerHandlers, Type};
 use pgwire::error::{PgWireError, PgWireResult};
 use pgwire::types::format::FormatOptions;
 
-use crate::auth::AuthManager;
 use crate::client;
-use crate::hooks::permissions::PermissionsHook;
 use crate::hooks::set_show::SetShowHook;
 use crate::hooks::transactions::TransactionStatementHook;
 use crate::hooks::QueryHook;
@@ -44,9 +42,8 @@ pub struct HandlerFactory {
 }
 
 impl HandlerFactory {
-    pub fn new(session_context: Arc<SessionContext>, auth_manager: Arc<AuthManager>) -> Self {
-        let session_service =
-            Arc::new(DfSessionService::new(session_context, auth_manager.clone()));
+    pub fn new(session_context: Arc<SessionContext>) -> Self {
+        let session_service = Arc::new(DfSessionService::new(session_context));
         HandlerFactory { session_service }
     }
 
@@ -99,15 +96,9 @@ pub struct DfSessionService {
 }
 
 impl DfSessionService {
-    pub fn new(
-        session_context: Arc<SessionContext>,
-        auth_manager: Arc<AuthManager>,
-    ) -> DfSessionService {
-        let hooks: Vec<Arc<dyn QueryHook>> = vec![
-            Arc::new(PermissionsHook::new(auth_manager)),
-            Arc::new(SetShowHook),
-            Arc::new(TransactionStatementHook),
-        ];
+    pub fn new(session_context: Arc<SessionContext>) -> DfSessionService {
+        let hooks: Vec<Arc<dyn QueryHook>> =
+            vec![Arc::new(SetShowHook), Arc::new(TransactionStatementHook)];
         Self::new_with_hooks(session_context, hooks)
     }
 

datafusion-postgres/src/lib.rs

@@ -21,7 +21,6 @@ use tokio::sync::Semaphore;
 use tokio_rustls::rustls::{self, ServerConfig};
 use tokio_rustls::TlsAcceptor;
 
-use crate::auth::AuthManager;
 use handlers::HandlerFactory;
 pub use handlers::{DfSessionService, Parser};
 pub use hooks::QueryHook;
@@ -86,10 +85,9 @@ fn setup_tls(cert_path: &str, key_path: &str) -> Result<TlsAcceptor, IOError> {
 pub async fn serve(
     session_context: Arc<SessionContext>,
     opts: &ServerOptions,
-    auth_manager: Arc<AuthManager>,
 ) -> Result<(), std::io::Error> {
     // Create the handler factory with authentication
-    let factory = Arc::new(HandlerFactory::new(session_context, auth_manager));
+    let factory = Arc::new(HandlerFactory::new(session_context));
 
     serve_with_handlers(factory, opts).await
 }

datafusion-postgres/src/testing.rs

@@ -21,7 +21,7 @@ pub fn setup_handlers() -> DfSessionService {
     )
     .expect("Failed to setup sesession context");
 
-    DfSessionService::new(Arc::new(session_context), Arc::new(AuthManager::new()))
+    DfSessionService::new(Arc::new(session_context))
 }
 
 #[derive(Debug, Default)]