-
Notifications
You must be signed in to change notification settings - Fork 13
refactor: upgraded storybook #5425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Storybook from version 9.1.13 to version 10.0.5 across all storybook configurations in the monorepo. The upgrade includes automated ESM migrations, removal of the eslint-plugin-storybook dependency, and package.json formatting improvements.
- Upgraded all Storybook packages from 9.1.13 to 10.0.5
- Applied automated ESM format migrations to main.ts configuration files
- Removed
eslint-plugin-storybookdependency and usage across all storybook packages
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| storybooks/vue-storybook/package.json | Updated Storybook dependencies to 10.0.5, removed eslint-plugin-storybook, reordered package.json fields |
| storybooks/vue-storybook/.storybook/main.ts | Added ESM migration with createRequire for module resolution |
| storybooks/react-storybook/package.json | Updated Storybook dependencies to 10.0.5, removed eslint-plugin-storybook |
| storybooks/react-storybook/eslint.config.js | Updated Storybook eslint plugin reference URL and commented out import |
| storybooks/react-storybook/.storybook/main.ts | Added ESM migration with createRequire for module resolution |
| storybooks/angular-storybook/package.json | Updated Storybook dependencies to 10.0.5, added storybook core package |
| storybooks/angular-storybook/.storybook/main.ts | Added ESM migration with createRequire for module resolution |
| storybooks/_storybook/package.json | Updated Storybook dependencies to 10.0.5, removed eslint-plugin-storybook |
| storybooks/_storybook/eslint.config.js | Updated Storybook eslint plugin reference URL and commented out import |
| storybooks/_storybook/.storybook/main.ts | Added ESM migration with createRequire and applied getAbsolutePath to addons |
| eslint.config.js | Added Storybook eslint plugin reference comment (not actively used) |
as it doesn't seem to work only being installed in the workspace
Proposed changes
storybookas a dependency tostorybooks/angular-storybook/package.jsonas suggested by the upgrade scriptgeneral information
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-upgraded-storybook