refactor: remove generic from Operation trait

roeap · roeap · commit 0f7c2fdd7ba5 · 2025-10-20T06:16:48.000+02:00
Signed-off-by: Robert Pack &lt;robstar.pack@gmail.com&gt;
diff --git a/crates/core/src/operations/add_column.rs b/crates/core/src/operations/add_column.rs
@@ -29,7 +29,7 @@ pub struct AddColumnBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl Operation<()> for AddColumnBuilder {
+impl Operation for AddColumnBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/add_feature.rs b/crates/core/src/operations/add_feature.rs
@@ -29,7 +29,7 @@ pub struct AddTableFeatureBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for AddTableFeatureBuilder {
+impl super::Operation for AddTableFeatureBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/constraints.rs b/crates/core/src/operations/constraints.rs
@@ -41,7 +41,7 @@ pub struct ConstraintBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for ConstraintBuilder {
+impl super::Operation for ConstraintBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/convert_to_delta.rs b/crates/core/src/operations/convert_to_delta.rs
@@ -168,7 +168,7 @@ impl Default for ConvertToDeltaBuilder {
     }
 }
 
-impl super::Operation<()> for ConvertToDeltaBuilder {
+impl super::Operation for ConvertToDeltaBuilder {
     fn log_store(&self) -> &LogStoreRef {
         self.log_store
             .as_ref()
diff --git a/crates/core/src/operations/create.rs b/crates/core/src/operations/create.rs
@@ -68,7 +68,7 @@ pub struct CreateBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for CreateBuilder {
+impl super::Operation for CreateBuilder {
     fn log_store(&self) -> &LogStoreRef {
         self.log_store
             .as_ref()
diff --git a/crates/core/src/operations/delete.rs b/crates/core/src/operations/delete.rs
@@ -114,7 +114,7 @@ pub struct DeleteMetrics {
     pub rewrite_time_ms: u64,
 }
 
-impl super::Operation<()> for DeleteBuilder {
+impl super::Operation for DeleteBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/drop_constraints.rs b/crates/core/src/operations/drop_constraints.rs
@@ -28,7 +28,7 @@ pub struct DropConstraintBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for DropConstraintBuilder {
+impl super::Operation for DropConstraintBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/filesystem_check.rs b/crates/core/src/operations/filesystem_check.rs
@@ -101,7 +101,7 @@ fn is_absolute_path(path: &str) -> DeltaResult<bool> {
     }
 }
 
-impl super::Operation<()> for FileSystemCheckBuilder {
+impl super::Operation for FileSystemCheckBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/load.rs b/crates/core/src/operations/load.rs
@@ -36,7 +36,7 @@ impl std::fmt::Debug for LoadBuilder {
     }
 }
 
-impl super::Operation<()> for LoadBuilder {
+impl super::Operation for LoadBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/merge/mod.rs b/crates/core/src/operations/merge/mod.rs
@@ -155,7 +155,7 @@ pub struct MergeBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for MergeBuilder {
+impl super::Operation for MergeBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/mod.rs b/crates/core/src/operations/mod.rs
@@ -96,7 +96,7 @@ pub trait CustomExecuteHandler: Send + Sync {
 #[allow(unused)]
 /// The [Operation] trait defines common behaviors that all operations builders
 /// should have consistent
-pub(crate) trait Operation<State>: std::future::IntoFuture {
+pub(crate) trait Operation: std::future::IntoFuture {
     fn log_store(&self) -> &LogStoreRef;
     fn get_custom_execute_handler(&self) -> Option<Arc<dyn CustomExecuteHandler>>;
     async fn pre_execute(&self, operation_id: Uuid) -> DeltaResult<()> {
diff --git a/crates/core/src/operations/optimize.rs b/crates/core/src/operations/optimize.rs
@@ -225,7 +225,7 @@ pub struct OptimizeBuilder<'a> {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for OptimizeBuilder<'_> {
+impl super::Operation for OptimizeBuilder<'_> {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/restore.rs b/crates/core/src/operations/restore.rs
@@ -95,7 +95,7 @@ pub struct RestoreBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for RestoreBuilder {
+impl super::Operation for RestoreBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/set_tbl_properties.rs b/crates/core/src/operations/set_tbl_properties.rs
@@ -28,7 +28,7 @@ pub struct SetTablePropertiesBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for SetTablePropertiesBuilder {
+impl super::Operation for SetTablePropertiesBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/update.rs b/crates/core/src/operations/update.rs
@@ -125,7 +125,7 @@ pub struct UpdateMetrics {
     pub scan_time_ms: u64,
 }
 
-impl super::Operation<()> for UpdateBuilder {
+impl super::Operation for UpdateBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/update_field_metadata.rs b/crates/core/src/operations/update_field_metadata.rs
@@ -30,7 +30,7 @@ pub struct UpdateFieldMetadataBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for UpdateFieldMetadataBuilder {
+impl super::Operation for UpdateFieldMetadataBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/update_table_metadata.rs b/crates/core/src/operations/update_table_metadata.rs
@@ -55,7 +55,7 @@ pub struct UpdateTableMetadataBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for UpdateTableMetadataBuilder {
+impl super::Operation for UpdateTableMetadataBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/vacuum.rs b/crates/core/src/operations/vacuum.rs
@@ -113,7 +113,7 @@ pub struct VacuumBuilder {
     custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,
 }
 
-impl super::Operation<()> for VacuumBuilder {
+impl super::Operation for VacuumBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }
diff --git a/crates/core/src/operations/write/mod.rs b/crates/core/src/operations/write/mod.rs
@@ -178,7 +178,7 @@ pub struct WriteMetrics {
     pub execution_time_ms: u64,
 }
 
-impl super::Operation<()> for WriteBuilder {
+impl super::Operation for WriteBuilder {
     fn log_store(&self) -> &LogStoreRef {
         &self.log_store
     }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ pub struct AddColumnBuilder {`
`29`	`29`	`custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,`
`30`	`30`	`}`
`31`	`31`
`32`		`-impl Operation<()> for AddColumnBuilder {`
	`32`	`+impl Operation for AddColumnBuilder {`
`33`	`33`	`fn log_store(&self) -> &LogStoreRef {`
`34`	`34`	`&self.log_store`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ pub struct AddTableFeatureBuilder {`
`29`	`29`	`custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,`
`30`	`30`	`}`
`31`	`31`
`32`		`-impl super::Operation<()> for AddTableFeatureBuilder {`
	`32`	`+impl super::Operation for AddTableFeatureBuilder {`
`33`	`33`	`fn log_store(&self) -> &LogStoreRef {`
`34`	`34`	`&self.log_store`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ pub struct ConstraintBuilder {`
`41`	`41`	`custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,`
`42`	`42`	`}`
`43`	`43`
`44`		`-impl super::Operation<()> for ConstraintBuilder {`
	`44`	`+impl super::Operation for ConstraintBuilder {`
`45`	`45`	`fn log_store(&self) -> &LogStoreRef {`
`46`	`46`	`&self.log_store`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ impl Default for ConvertToDeltaBuilder {`
`168`	`168`	`}`
`169`	`169`	`}`
`170`	`170`
`171`		`-impl super::Operation<()> for ConvertToDeltaBuilder {`
	`171`	`+impl super::Operation for ConvertToDeltaBuilder {`
`172`	`172`	`fn log_store(&self) -> &LogStoreRef {`
`173`	`173`	`self.log_store`
`174`	`174`	`.as_ref()`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ pub struct CreateBuilder {`
`68`	`68`	`custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,`
`69`	`69`	`}`
`70`	`70`
`71`		`-impl super::Operation<()> for CreateBuilder {`
	`71`	`+impl super::Operation for CreateBuilder {`
`72`	`72`	`fn log_store(&self) -> &LogStoreRef {`
`73`	`73`	`self.log_store`
`74`	`74`	`.as_ref()`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ pub struct DeleteMetrics {`
`114`	`114`	`pub rewrite_time_ms: u64,`
`115`	`115`	`}`
`116`	`116`
`117`		`-impl super::Operation<()> for DeleteBuilder {`
	`117`	`+impl super::Operation for DeleteBuilder {`
`118`	`118`	`fn log_store(&self) -> &LogStoreRef {`
`119`	`119`	`&self.log_store`
`120`	`120`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ pub struct DropConstraintBuilder {`
`28`	`28`	`custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,`
`29`	`29`	`}`
`30`	`30`
`31`		`-impl super::Operation<()> for DropConstraintBuilder {`
	`31`	`+impl super::Operation for DropConstraintBuilder {`
`32`	`32`	`fn log_store(&self) -> &LogStoreRef {`
`33`	`33`	`&self.log_store`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ fn is_absolute_path(path: &str) -> DeltaResult<bool> {`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`
`104`		`-impl super::Operation<()> for FileSystemCheckBuilder {`
	`104`	`+impl super::Operation for FileSystemCheckBuilder {`
`105`	`105`	`fn log_store(&self) -> &LogStoreRef {`
`106`	`106`	`&self.log_store`
`107`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ impl std::fmt::Debug for LoadBuilder {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`		`-impl super::Operation<()> for LoadBuilder {`
	`39`	`+impl super::Operation for LoadBuilder {`
`40`	`40`	`fn log_store(&self) -> &LogStoreRef {`
`41`	`41`	`&self.log_store`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ pub struct MergeBuilder {`
`155`	`155`	`custom_execute_handler: Option<Arc<dyn CustomExecuteHandler>>,`
`156`	`156`	`}`
`157`	`157`
`158`		`-impl super::Operation<()> for MergeBuilder {`
	`158`	`+impl super::Operation for MergeBuilder {`
`159`	`159`	`fn log_store(&self) -> &LogStoreRef {`
`160`	`160`	`&self.log_store`
`161`	`161`	`}`