Skip to content

Commit 394c849

Browse files
Merge pull request #111 from carlthome/upgrade-dependencies
Update protobuf version, allow newer matplotlib, update GitHub Actions test workflow
2 parents 7776c29 + 6382c87 commit 394c849

File tree

2 files changed

+11
-19
lines changed

2 files changed

+11
-19
lines changed

.github/workflows/pr.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
name: pr
1+
name: Test
2+
23
on: pull_request
34

45
jobs:
@@ -8,36 +9,28 @@ jobs:
89
- uses: actions/checkout@v2
910
# Run isort + black formatter
1011
- name: Python Code Formatter
11-
uses: descriptinc/python-format-action@master
12+
uses: descriptinc/python-format-action@main
1213

1314
build:
1415
runs-on: ubuntu-latest
1516
strategy:
1617
matrix:
17-
python-version: [3.7, 3.8, 3.9]
18+
python-version: ["3.8", "3.9", "3.10", "3.11"]
1819

1920
steps:
2021
- uses: actions/checkout@v2
2122
with:
2223
lfs: true
2324
- name: Set up Python ${{ matrix.python-version }}
24-
uses: actions/setup-python@v1
25+
uses: actions/setup-python@v5
2526
with:
2627
python-version: ${{ matrix.python-version }}
27-
- uses: actions/cache@v1
28-
id: cache
29-
with:
30-
path: ~/.cache/pip
31-
key: ${{ runner.os }}-${{ matrix.python-version }}-pip-${{ hashFiles('**/*requirements.txt') }}
32-
restore-keys: |
33-
${{ runner.os }}-${{ matrix.python-version }}-pip-
34-
- name: Checkout LFS objects
35-
run: git lfs checkout
28+
cache: pip
29+
cache-dependency-path: setup.py
3630
- name: Install binaries
3731
run: |
3832
sudo apt-get update
39-
sudo apt-get install ffmpeg
40-
sudo apt-get install libsndfile1-dev libsox-dev libsox-fmt-mp3
33+
sudo apt-get install ffmpeg libsndfile1-dev libsox-dev libsox-fmt-mp3
4134
python -m pip install --upgrade pip
4235
pip install wheel
4336
- name: Install recent FFMPEG

setup.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,15 @@
4646
"ffmpy",
4747
"ipython",
4848
"rich",
49-
"matplotlib==3.5", # See https://github.com/librosa/librosa/issues/1763#issuecomment-1742120524
49+
"matplotlib",
5050
"librosa",
5151
"pystoi",
5252
"torch_stoi",
5353
"flatten-dict",
5454
"markdown2",
5555
"randomname",
56-
# Have to freeze protobuf version, https://github.com/protocolbuffers/protobuf/issues/10051
57-
# Borrowing pin from tensorboard source: https://github.com/tensorflow/tensorboard/commit/fd4f5ff79374252e313c2e7e9b247bc49ab0d54d.
58-
"protobuf >= 3.9.2, < 3.20",
56+
# Borrowing pin from tensorboard source: https://github.com/tensorflow/tensorboard/commit/e795312f70537cb9c9ab4bd2a08a03e77f0356a5.
57+
"protobuf >= 3.19.6, != 4.24.0, < 5.0.0",
5958
"tensorboard",
6059
"tqdm",
6160
],

0 commit comments

Comments
 (0)