Skip to content

Commit 794143d

Browse files
committed
default e.target should be source object
1 parent 11d2a39 commit 794143d

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

src/jquery.observable/jquery.observable.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,8 @@ var storageExpando = '__' + +new Date + 'storage',
168168
e = $.Event(_this.buildEventName(rawType = e)) :
169169
e.type = _this.buildEventName(rawType = e.type);
170170

171+
e.target || (e.target = _this);
172+
171173
if(storage && (storage = storage[e.type])) {
172174
var item = storage.list.first,
173175
ret;

src/jquery.observable/jquery.observable.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/jquery.observable/jquery.observable.specs.js

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe('jquery.observable specs', function() {
99
fn3 = jasmine.createSpy();
1010
});
1111

12-
describe('on, once and trigger methods spces', function() {
12+
describe('on, once and trigger methods specs', function() {
1313
it('should be valid callbacks called', function() {
1414
observable.on('e1', fn1);
1515
observable.on('e1', fn2);
@@ -90,6 +90,22 @@ describe('jquery.observable specs', function() {
9090
expect(fn2).not.toHaveBeenCalled();
9191
expect(fn3).not.toHaveBeenCalled();
9292
});
93+
94+
it('should be expected default target', function() {
95+
observable.on('e1', fn1);
96+
observable.trigger('e1');
97+
98+
expect(fn1.mostRecentCall.args[0].target).toBe(observable);
99+
});
100+
101+
it('should be expected custom target', function() {
102+
var target = {},
103+
e = $.Event('e1', { target : target });
104+
observable.on('e1', fn1);
105+
observable.trigger(e);
106+
107+
expect(fn1.mostRecentCall.args[0].target).toBe(target);
108+
});
93109
});
94110

95111
});

0 commit comments

Comments
 (0)