Fix header typo in mineral-plan.csv#360
Conversation
Code ReviewThanks for this fix! The column renames look correct — aligning with the A few things worth flagging: Bug: Generator script not updatedThe script that generates these CSV files still uses the old column names and will overwrite the fix if re-run:
mineral_count = create_plans_csv(melted_df, ['M', 'M;W'], 'dataset/mineral-plan.csv', 'mineral-planning-boundary')
waste_count = create_plans_csv(melted_df, ['W', 'M;W'], 'dataset/waste-plan.csv', 'waste-planning-boundary')These should be updated to Minor: PR title is incompleteThe title says "Fix header typo in mineral-plan.csv" but Minor: PR description is unfilledThe PR description is the template with placeholder text. It would help reviewers to understand the intent — even a one-liner explaining that these column names should follow the No testsFor a pure data/CSV change this may be acceptable, but worth noting that if there are any schema validation tests for these CSV files they should also be checked. The data change itself looks correct, but the generator script mismatch is a real concern and should be addressed before merging. |
|
Code Review - see details below |
What type of PR is this? (check all applicable)
Description
Please replace this line with a brief description of the changes made.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?