Skip to content

Fix header typo in mineral-plan.csv#360

Merged
Ben-Hodgkiss merged 2 commits into
mainfrom
Update-M&W-headers
Mar 11, 2026
Merged

Fix header typo in mineral-plan.csv#360
Ben-Hodgkiss merged 2 commits into
mainfrom
Update-M&W-headers

Conversation

@Ben-Hodgkiss
Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Please replace this line with a brief description of the changes made.

Related Tickets & Documents

  • Ticket Link
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@Ben-Hodgkiss Ben-Hodgkiss merged commit 356b9f4 into main Mar 11, 2026
1 check passed
@Ben-Hodgkiss Ben-Hodgkiss deleted the Update-M&W-headers branch March 11, 2026 09:26
@claude
Copy link
Copy Markdown

claude Bot commented Mar 11, 2026

Code Review

Thanks for this fix! The column renames look correct — aligning with the {dataset}-plan-boundary naming convention used elsewhere (e.g. local-plan-boundary.csv, mineral-plan-boundary.csv, waste-plan-boundary.csv).

A few things worth flagging:

Bug: Generator script not updated

The script that generates these CSV files still uses the old column names and will overwrite the fix if re-run:

bin/generate-timetable-data/generate_mineral_waste_timetable.py lines 1693–1697:

mineral_count = create_plans_csv(melted_df, ['M', 'M;W'], 'dataset/mineral-plan.csv', 'mineral-planning-boundary')
waste_count = create_plans_csv(melted_df, ['W', 'M;W'], 'dataset/waste-plan.csv', 'waste-planning-boundary')

These should be updated to 'mineral-plan-boundary' and 'waste-plan-boundary' respectively to keep the script and the CSV output in sync.

Minor: PR title is incomplete

The title says "Fix header typo in mineral-plan.csv" but waste-plan.csv is also changed. Something like "Fix boundary header names in mineral-plan and waste-plan CSVs" would be more accurate.

Minor: PR description is unfilled

The PR description is the template with placeholder text. It would help reviewers to understand the intent — even a one-liner explaining that these column names should follow the {dataset}-plan-boundary convention (rather than {dataset}-planning-boundary) would be useful.

No tests

For a pure data/CSV change this may be acceptable, but worth noting that if there are any schema validation tests for these CSV files they should also be checked.


The data change itself looks correct, but the generator script mismatch is a real concern and should be addressed before merging.

@claude
Copy link
Copy Markdown

claude Bot commented Mar 11, 2026

Code Review - see details below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant