fix: resolve all golangci-lint issues

- Fix misspelling: cancelled → canceled
- Add type assertion checks for ElemType conversions
- Add proper error handling for cleanup StorageVolDelete
- Use safe type assertion with ok check for type conversions

Author: dmacvicar

internal/libvirt/dialers/sshcmd.go

@@ -395,7 +395,9 @@ func (c *sshCmdConn) lastStderrLines() []string {
 		if el == nil {
 			return
 		}
-		lines = append(lines, el.(string))
+		if str, ok := el.(string); ok {
+			lines = append(lines, str)
+		}
 	})
 
 	return lines

internal/provider/domain_conversion.go

@@ -2202,7 +2202,12 @@ func xmlToDomainModel(ctx context.Context, domain *libvirtxml.Domain, model *Dom
 				},
 			},
 		}
-		filesystemsList := types.ListNull(filesystemsType.ElemType.(types.ObjectType))
+		filesystemsObjType, ok := filesystemsType.ElemType.(types.ObjectType)
+		if !ok {
+			diags.AddError("Type Error", "Expected filesystemsType.ElemType to be ObjectType")
+			return diags
+		}
+		filesystemsList := types.ListNull(filesystemsObjType)
 
 		if !model.Devices.IsNull() && !model.Devices.IsUnknown() {
 			var existingDevices DomainDevicesModel
@@ -2310,7 +2315,12 @@ func xmlToDomainModel(ctx context.Context, domain *libvirtxml.Domain, model *Dom
 				},
 			},
 		}
-		consolesList := types.ListNull(consolesType.ElemType.(types.ObjectType))
+		consolesObjType, ok := consolesType.ElemType.(types.ObjectType)
+		if !ok {
+			diags.AddError("Type Error", "Expected consolesType.ElemType to be ObjectType")
+			return diags
+		}
+		consolesList := types.ListNull(consolesObjType)
 
 		if !model.Devices.IsNull() && !model.Devices.IsUnknown() {
 			var existingDevices DomainDevicesModel
@@ -2375,7 +2385,12 @@ func xmlToDomainModel(ctx context.Context, domain *libvirtxml.Domain, model *Dom
 				},
 			},
 		}
-		serialsList := types.ListNull(serialsType.ElemType.(types.ObjectType))
+		serialsObjType, ok := serialsType.ElemType.(types.ObjectType)
+		if !ok {
+			diags.AddError("Type Error", "Expected serialsType.ElemType to be ObjectType")
+			return diags
+		}
+		serialsList := types.ListNull(serialsObjType)
 
 		if !model.Devices.IsNull() && !model.Devices.IsUnknown() {
 			var existingDevices DomainDevicesModel
@@ -2438,7 +2453,12 @@ func xmlToDomainModel(ctx context.Context, domain *libvirtxml.Domain, model *Dom
 				},
 			},
 		}
-		rngsList := types.ListNull(rngsType.ElemType.(types.ObjectType))
+		rngsObjType, ok := rngsType.ElemType.(types.ObjectType)
+		if !ok {
+			diags.AddError("Type Error", "Expected rngsType.ElemType to be ObjectType")
+			return diags
+		}
+		rngsList := types.ListNull(rngsObjType)
 
 		if !model.Devices.IsNull() && !model.Devices.IsUnknown() {
 			var existingDevices DomainDevicesModel
@@ -2487,7 +2507,12 @@ func xmlToDomainModel(ctx context.Context, domain *libvirtxml.Domain, model *Dom
 				},
 			},
 		}
-		tpmsList := types.ListNull(tpmsType.ElemType.(types.ObjectType))
+		tpmsObjType, ok := tpmsType.ElemType.(types.ObjectType)
+		if !ok {
+			diags.AddError("Type Error", "Expected tpmsType.ElemType to be ObjectType")
+			return diags
+		}
+		tpmsList := types.ListNull(tpmsObjType)
 
 		if !model.Devices.IsNull() && !model.Devices.IsUnknown() {
 			var existingDevices DomainDevicesModel

internal/provider/domain_resource.go

@@ -1741,7 +1741,7 @@ func waitForInterfaceIP(ctx context.Context, client *libvirt.Client, domain goli
 		// Wait before next poll
 		select {
 		case <-ctx.Done():
-			return fmt.Errorf("context cancelled while waiting for IP")
+			return fmt.Errorf("context canceled while waiting for IP")
 		case <-time.After(pollInterval):
 			// Continue polling
 		}

internal/provider/volume_resource.go

@@ -432,8 +432,12 @@ func (r *VolumeResource) Create(ctx context.Context, req resource.CreateRequest,
 		// The 0 flag means start at offset 0, uploadCapacity is the length
 		err = r.client.Libvirt().StorageVolUpload(volume, uploadStream.Reader, 0, uint64(uploadCapacity), 0)
 		if err != nil {
-			// Upload failed, try to clean up the volume
-			_ = r.client.Libvirt().StorageVolDelete(volume, 0)
+			// Upload failed, try to clean up the volume (ignore cleanup errors to preserve original error)
+			if delErr := r.client.Libvirt().StorageVolDelete(volume, 0); delErr != nil {
+				tflog.Warn(ctx, "Failed to delete volume during cleanup", map[string]any{
+					"error": delErr.Error(),
+				})
+			}
 			resp.Diagnostics.AddError(
 				"Volume Upload Failed",
 				fmt.Sprintf("Failed to upload content to volume: %s", err),