Skip to content

Commit ff9d2b0

Browse files
authored
Merge pull request #146 from dnd-side-project/refactor/#145-memo
Refactor/#145 memo
2 parents d5ca384 + 1456dbf commit ff9d2b0

File tree

5 files changed

+4
-15
lines changed

5 files changed

+4
-15
lines changed

src/main/java/com/dnd/reevserver/domain/memo/dto/request/CreateMemoRequestDto.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@
22

33
import java.util.List;
44

5-
public record CreateMemoRequestDto(String title, String content, String templateName,
6-
List<String> categoriesName, Long groupId) {
5+
public record CreateMemoRequestDto(Long groupId, String title, String content, List<String> categoryNames) {
76
}

src/main/java/com/dnd/reevserver/domain/memo/dto/response/MemoResponseDto.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66

77
@Builder
88
public record MemoResponseDto(Long memoId, String userId, String title,
9-
String content, String templateName, List<String> categories, Long groupId){
9+
String content, List<String> categoryNames, Long groupId){
1010
}

src/main/java/com/dnd/reevserver/domain/memo/entity/Memo.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.dnd.reevserver.domain.category.entity.MemoCategory;
44
import com.dnd.reevserver.domain.member.entity.Member;
55
import com.dnd.reevserver.domain.team.entity.Team;
6-
import com.dnd.reevserver.domain.template.entity.Template;
76
import com.dnd.reevserver.global.common.entity.BaseEntity;
87
import jakarta.persistence.*;
98
import lombok.*;
@@ -33,10 +32,6 @@ public class Memo extends BaseEntity {
3332
@Column(name = "content", nullable = false, columnDefinition = "LONGTEXT")
3433
private String content;
3534

36-
@ManyToOne
37-
@JoinColumn(name = "template_id")
38-
private Template template;
39-
4035
@OneToMany(mappedBy = "memo", cascade = CascadeType.REMOVE, orphanRemoval = true)
4136
private List<MemoCategory> memoCategories = new ArrayList<>();
4237

src/main/java/com/dnd/reevserver/domain/memo/repository/MemoRepository.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,12 @@
1010
public interface MemoRepository extends JpaRepository<Memo, Long> {
1111
@Query("SELECT m FROM Memo m " +
1212
"JOIN FETCH m.member " +
13-
"JOIN FETCH m.template " +
1413
"JOIN FETCH m.team "+
1514
"WHERE m.member.userId = :userId")
1615
List<Memo> findMemosByMemberUserId(@Param("userId") String userId);
1716

1817
@Query("SELECT m FROM Memo m " +
1918
"JOIN FETCH m.member " +
20-
"JOIN FETCH m.template " +
2119
"JOIN FETCH m.team "+
2220
"WHERE m.member.userId = :userId " +
2321
"AND m.team.groupId = :groupId")

src/main/java/com/dnd/reevserver/domain/memo/service/MemoService.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,15 @@ public Integer countMemosByUserId(String userId){
6363
// 메모 생성
6464
@Transactional
6565
public void createMemo(String userId, CreateMemoRequestDto dto){
66-
Template template = templateService.findByName(dto.templateName());
6766
Memo memo = Memo.builder()
6867
.member(memberService.findById(userId))
6968
.title(dto.title())
7069
.content(dto.content())
71-
.template(template) // null 가능
7270
.team(dto.groupId() == null ? null : teamService.findById(dto.groupId())) // null 가능
7371
.build();
7472
// 메모-태그 생성
7573
memoRepository.save(memo);
76-
List<Category> categories = categoryRepository.findByCategoryNameIn(dto.categoriesName());
74+
List<Category> categories = categoryRepository.findByCategoryNameIn(dto.categoryNames());
7775
List<MemoCategory> mcList = categories.stream()
7876
.map(category -> new MemoCategory(memo, category))
7977
.collect(Collectors.toList());
@@ -94,8 +92,7 @@ private MemoResponseDto convertToDto(Memo memo){
9492
.title(memo.getTitle())
9593
.userId(memo.getMember().getUserId())
9694
.content(memo.getContent())
97-
.templateName(memo.getTemplate().getTemplateName())
98-
.categories(
95+
.categoryNames(
9996
memo.getMemoCategories().stream()
10097
.map(mc -> mc.getCategory().getCategoryName())
10198
.toList()

0 commit comments

Comments
 (0)