Should use CFBundleName instead of CFDisplayBundleName for .app name

[LuKePicci]

I think this should use CFBundleName to determine output .app name, not CFBundleDisplayName

dotnet-bundle/DotNet.Bundle/StructureBuilder.cs

Line 18 in 7e681e6

public string AppDirectory => Path.Combine(Path.Combine(PublishDirectory, _task.CFBundleDisplayName + ".app"));

[x2bool]

Why? Is there any reason CFBundleName is better?

https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundlename

https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundledisplayname

[LuKePicci]

Because that is what I read on https://github.com/egramtel/dotnet-bundle/blob/master/README.md:

<CFBundleName>AppName</CFBundleName> <!-- Also defines .app file name -->
<CFBundleDisplayName>App Name</CFBundleDisplayName>
<CFBundleIdentifier>com.example</CFBundleIdentifier>
...

And that is what Xcode does (and Visual Studio for Mac as well on Xamarin project templates)

[LuKePicci]

Actually it could be even better to have a separate option for setting bundle filename so I can avoid renaming my system extension bundles (which are required to have a filename matching their bundle identifier with .systemextension filename extension).

[x2bool]

Yes, I think we could go with custom property and fallback to CFBundleName if it's not set.