Updated "Update toast" using toast.pen#1271
Open
cbum-dev wants to merge 6 commits intoeigent-ai:mainfrom
Open
Conversation
…ast.pen as requested by maintainer\n- Fix alignment: increase toast body padding to align text with header icon
…ick to stop'\n- Mute status text color to match design spec\n- Ensure action text remains primary color
Contributor
|
thanks @cbum-dev for the contribution! could @a7m-1st and @Zephyroam help reviewing this? |
Zephyroam
reviewed
Feb 16, 2026
| <UpdateToastShell | ||
| toastId={toastId} | ||
| onClose={() => { | ||
| setIsDownloading(false); |
Collaborator
There was a problem hiding this comment.
So the downloading is not actually cancelled. But I guess the original implementation was not doing anything as well, right?
Contributor
Author
There was a problem hiding this comment.
Yeah for now it's just hiding the toast. Any endpoint present in the backend to stop the update?
Collaborator
|
Thanks @cbum-dev for the contribution! The new toast design looks much cleaner, I have a few suggestions below — happy to discuss if anything is unclear. |
4pmtong
requested changes
Mar 10, 2026
| <Package className="h-4 w-4 text-icon-primary" strokeWidth={1.33} /> | ||
| <span | ||
| className="font-bold text-text-heading" | ||
| style={{ fontSize: '13px', lineHeight: '20px' }} |
Collaborator
There was a problem hiding this comment.
Could we use Tailwind classes instead of inline styles?
Comment on lines
+179
to
+185
| <span | ||
| className="cursor-pointer font-medium text-text-primary decoration-text-label hover:decoration-text-primary" | ||
| style={{ fontSize: '10px', lineHeight: '16px' }} | ||
| onClick={() => window.ipcRenderer.invoke('quit-and-install')} | ||
| > | ||
| {t('update.click-to-restart')} | ||
| </span> |
Collaborator
There was a problem hiding this comment.
Could we use button instead of span? it would be more accessible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1141
Description
Updated update toast using toast.pen
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement