Merge pull request #72 from ekino/fix-panther-usage

fancyweb · web-flow · commit 29dea6e1cfa8 · 2019-06-11T10:57:37.000+03:00
fix(tests): fix tests and CI
diff --git a/composer.json b/composer.json
@@ -58,7 +58,7 @@
         "phpunit/phpunit": "^7.5",
         "symfony/browser-kit": "^3.4 || ^4.0",
         "symfony/finder": "^3.4 || ^4.0",
-        "symfony/panther": "1.0.x-dev",
+        "symfony/panther": "dev-master#f76f91e94c1f29117963d8625f47462a930a03e2",
         "symfony/process": "^3.4.2 || ^4.0.2"
     },
     "extra": {
diff --git a/tests/Integration/Action/DisplayPrettyExceptions/DisplayPrettyExceptionsActionTest.php b/tests/Integration/Action/DisplayPrettyExceptions/DisplayPrettyExceptionsActionTest.php
@@ -38,7 +38,6 @@ protected function doTestTargetedBehaviorWithDebugKernel(Client $client): void
     {
         $text = $client->request('GET', '/')->text();
 
-        $this->assertContains('Whoops, looks like something went wrong.', $text);
         $this->assertContains('This is an useless exception message.', $text);
         $this->assertThat($text, $this->logicalOr(
             $this->stringContains('in throw_uncaught_exception.module line 5', false),
diff --git a/tests/Integration/Action/DisplayPrettyExceptionsASAP/DisplayPrettyExceptionsASAPActionTest.php b/tests/Integration/Action/DisplayPrettyExceptionsASAP/DisplayPrettyExceptionsASAPActionTest.php
@@ -83,7 +83,6 @@ protected function doTestInitialBehaviorWithDrupalKernel(Client $client): void
     protected function doTestTargetedBehaviorWithDebugKernel(Client $client): void
     {
         $text = $client->request('GET', '/')->text();
-        $this->assertContains('Whoops, looks like something went wrong.', $text);
         $this->assertContains('My custom exception message is great!', $text);
         $this->assertThat($text, $this->logicalOr(
             $this->stringContains('in throw_uncaught_exception.module line 5', false),

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,6 @@ protected function doTestTargetedBehaviorWithDebugKernel(Client $client): void`
`38`	`38`	`{`
`39`	`39`	`$text = $client->request('GET', '/')->text();`
`40`	`40`
`41`		`- $this->assertContains('Whoops, looks like something went wrong.', $text);`
`42`	`41`	`$this->assertContains('This is an useless exception message.', $text);`
`43`	`42`	`$this->assertThat($text, $this->logicalOr(`
`44`	`43`	`$this->stringContains('in throw_uncaught_exception.module line 5', false),`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ protected function doTestInitialBehaviorWithDrupalKernel(Client $client): void`
`83`	`83`	`protected function doTestTargetedBehaviorWithDebugKernel(Client $client): void`
`84`	`84`	`{`
`85`	`85`	`$text = $client->request('GET', '/')->text();`
`86`		`- $this->assertContains('Whoops, looks like something went wrong.', $text);`
`87`	`86`	`$this->assertContains('My custom exception message is great!', $text);`
`88`	`87`	`$this->assertThat($text, $this->logicalOr(`
`89`	`88`	`$this->stringContains('in throw_uncaught_exception.module line 5', false),`