Skip to content

Conversation

@seanzatzdev
Copy link
Contributor

@seanzatzdev seanzatzdev commented Nov 11, 2025

The memory limit in testMaybeSample was set too low for certain seeds & size of samples was surpassing the 100kb limit about halfway through, this PR increases that limit to 500kb and unmutes the test.

closes #137871

@seanzatzdev seanzatzdev marked this pull request as ready for review November 12, 2025 15:43
@seanzatzdev seanzatzdev requested a review from masseyke November 12, 2025 15:43
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Nov 12, 2025
@seanzatzdev seanzatzdev added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Nov 12, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label labels Nov 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@seanzatzdev seanzatzdev removed the Team:Data Management Meta label for data/management team label Nov 12, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Nov 12, 2025
@seanzatzdev seanzatzdev requested a review from a team November 12, 2025 16:05
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanzatzdev seanzatzdev merged commit a53166f into elastic:main Nov 12, 2025
34 checks passed
@seanzatzdev seanzatzdev deleted the fix-sampling-service-test branch November 12, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue Team:Data Management Meta label for data/management team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] SamplingServiceTests testMaybeSample failing

3 participants