build: switch to npm-based init checks and add npm and yarn version checking

Author: tkajtoch

packages/release-cli/package.json

@@ -15,13 +15,15 @@
   },
   "devDependencies": {
     "@types/prompts": "^2.4.9",
+    "@types/semver": "^7",
     "typescript": "^5.7.3"
   },
   "dependencies": {
     "chalk": "^4",
     "glob": "^11.0.1",
     "prompts": "^2.4.2",
     "rimraf": "^6.0.1",
+    "semver": "^7.7.3",
     "yargs": "^17.7.2"
   }
 }

packages/release-cli/src/npm_utils.ts

@@ -57,3 +57,30 @@ export const npmExecPublish = ({
     { stdio: 'inherit', encoding: 'utf8' }
   );
 };
+
+export const getNpmRegistryServer = async () => {
+  const result = await execPromise('npm config get registry');
+  const url = result.stdout.trim();
+
+  return {
+    url,
+    isOfficial: url === 'https://registry.npmjs.org/',
+  };
+}
+
+export const getNpmAuthenticatedUser = async () => {
+  const result = await execPromise('npm whoami --json');
+  const data = JSON.parse(result.stdout);
+
+  if (typeof data === 'string') {
+    return data;
+  }
+
+  return null;
+};
+
+
+export const getNpmVersion = async () => {
+  const result = await execPromise('npm -v');
+  return result.stdout.trim();
+};

packages/release-cli/src/steps/init_checks.ts

@@ -8,6 +8,7 @@
 
 import chalk from 'chalk';
 import prompts from 'prompts';
+import semver from 'semver';
 
 import { ValidationError } from '../errors';
 import { type ReleaseOptions } from '../release';
@@ -18,7 +19,42 @@ import {
   getRemoteHeadCommitHash,
   isWorkingTreeClean,
 } from '../git_utils';
-import { getAuthenticatedUser, getYarnRegistryServer } from '../yarn_utils';
+import {
+  getNpmAuthenticatedUser,
+  getNpmRegistryServer,
+  getNpmVersion,
+} from '../npm_utils';
+import { getYarnVersion } from '../yarn_utils';
+
+const checkNpmYarnVersions = async (options: ReleaseOptions) => {
+  const { logger } = options;
+
+  let npmVersion, yarnVersion;
+  try {
+    npmVersion = await getNpmVersion();
+  } catch (err) {
+    throw new ValidationError(
+      'Unable to check npm version. Ensure `npm` is installed and available in PATH'
+    );
+  }
+
+  // npm v11.5.1 is required for trusted publishing
+  if (semver.lt(npmVersion, '11.5.1')) {
+    throw new ValidationError(
+      'The version of npm installed on your system is lower than the required version. Please install npm v11.5.1 or newer.'
+    );
+  }
+
+  try {
+    yarnVersion = await getYarnVersion();
+  } catch (err) {
+    throw new ValidationError(
+      'Unable to check yarn version. Ensure `yarn` is installed and available in PATH'
+    );
+  }
+
+  logger.info(`Using npm v${npmVersion} and yarn v${yarnVersion}`);
+};
 
 /**
  * Check current git branch, working tree status and more to ensure
@@ -40,7 +76,7 @@ export const stepInitChecks = async (options: ReleaseOptions) => {
   if (!(await isWorkingTreeClean())) {
     throw new ValidationError(
       'Git working tree is dirty. Please clean up your working tree' +
-      ' from any uncommited changes and try again.',
+        ' from any uncommited changes and try again.',
       `To clean local changes and restore the branch to remote state,` +
         ` please run:\n  ${chalk.yellowBright(
           `git reset --hard upstream/${currentBranch}`
@@ -75,14 +111,16 @@ export const stepInitChecks = async (options: ReleaseOptions) => {
     )}) on branch ${chalk.underline.bold(currentBranch)}`
   );
 
+  await checkNpmYarnVersions(options);
+
   if (!options.skipAuthCheck) {
-    const registryUser = await getAuthenticatedUser();
+    const registryUser = await getNpmAuthenticatedUser();
     if (!registryUser) {
       throw new ValidationError(
         'Authentication to npmjs is required. Please log in before running' +
           ' this command again.',
         `To authenticate run the following command:\n` +
-          `  ${chalk.yellowBright('yarn npm login')}`
+          `  ${chalk.yellowBright('npm login')}`
       );
     }
 
@@ -91,11 +129,11 @@ export const stepInitChecks = async (options: ReleaseOptions) => {
     logger.info('Skipping the registry authentication check');
   }
 
-  const npmRegistry = await getYarnRegistryServer();
-  if (npmRegistry) {
+  const npmRegistry = await getNpmRegistryServer();
+  if (!npmRegistry.isOfficial) {
     logger.warning(
       chalk.yellow(
-        `A custom npm registry server (${npmRegistry}) will be used!`
+        `A custom npm registry server (${npmRegistry.url}) will be used!`
       )
     );
   } else {

packages/release-cli/src/yarn_utils.ts

@@ -104,48 +104,7 @@ export const yarnPack = async (workspace: string)=> {
   return details;
 };
 
-export const getAuthenticatedUser = async () => {
-  try {
-    const result = await execPromise('yarn npm whoami');
-    // npmjs usernames can only contain alphanumeric characters and hypens
-    const [_, username] = result.stdout.split('\n')[0].split(': ');
-
-    // yarn npm whoami can return `undefined` in certain cases
-    if (!username || username === 'undefined') {
-      return null;
-    }
-
-    return username;
-  } catch (err) {
-    return null;
-  }
-};
-
-export const getYarnRegistryServer = async () => {
-  // Yarn supports scoped and non-scoped/global settings.
-  // We must check both to ensure we get the correct value
-
-  const getOutput = async (cmd: string) => {
-    const result = await execPromise(cmd);
-    const rawOutput = result.stdout.trim();
-    if (rawOutput === 'undefined') {
-      return null;
-    }
-
-    const output = JSON.parse(rawOutput);
-    if (!output || output === '') {
-      return null;
-    }
-
-    return output;
-  }
-
-  const scopedOutput = await getOutput(`yarn config get 'npmScopes["elastic"].npmRegistryServer' --json`);
-  if (scopedOutput !== null) {
-    return scopedOutput;
-  }
-
-  // return await to keep the rejection behavior the same
-  // for both getOutput calls
-  return await getOutput('yarn config get npmRegistryServer --json');
+export const getYarnVersion = async () => {
+  const result = await execPromise('yarn -v');
+  return result.stdout.trim();
 };

yarn.lock

@@ -7158,10 +7158,12 @@ __metadata:
   resolution: "@elastic/eui-release-cli@workspace:packages/release-cli"
   dependencies:
     "@types/prompts": "npm:^2.4.9"
+    "@types/semver": "npm:^7"
     chalk: "npm:^4"
     glob: "npm:^11.0.1"
     prompts: "npm:^2.4.2"
     rimraf: "npm:^6.0.1"
+    semver: "npm:^7.7.3"
     typescript: "npm:^5.7.3"
     yargs: "npm:^17.7.2"
   languageName: unknown
@@ -11546,6 +11548,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@types/semver@npm:^7":
+  version: 7.7.1
+  resolution: "@types/semver@npm:7.7.1"
+  checksum: 10c0/c938aef3bf79a73f0f3f6037c16e2e759ff40c54122ddf0b2583703393d8d3127130823facb880e694caa324eb6845628186aac1997ee8b31dc2d18fafe26268
+  languageName: node
+  linkType: hard
+
 "@types/semver@npm:^7.1.0, @types/semver@npm:^7.5.0":
   version: 7.5.8
   resolution: "@types/semver@npm:7.5.8"
@@ -36865,6 +36874,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"semver@npm:^7.7.3":
+  version: 7.7.3
+  resolution: "semver@npm:7.7.3"
+  bin:
+    semver: bin/semver.js
+  checksum: 10c0/4afe5c986567db82f44c8c6faef8fe9df2a9b1d98098fc1721f57c696c4c21cebd572f297fc21002f81889492345b8470473bc6f4aff5fb032a6ea59ea2bc45e
+  languageName: node
+  linkType: hard
+
 "send@npm:0.18.0":
   version: 0.18.0
   resolution: "send@npm:0.18.0"