[PoC] Cached panel field specs #242335
Draft
[PoC] Cached panel field specs #242335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
drewdaemon
commented
Nov 7, 2025
| @@ -1073,7 +1079,8 @@ export class DataViewsService { | |||
| get = async ( | |||
| id: string, | |||
| displayErrors: boolean = true, | |||
| refreshFields = false | |||
| refreshFields = false, | |||
| fieldSpecs?: FieldSpec[] | |||
Contributor
Author
There was a problem hiding this comment.
This new parameter allows a client to supply the fields list for the data view, removing the need for a field fetch.
drewdaemon
commented
Nov 7, 2025
| initialState.serializedSearchSource | ||
| discoverServices.data, | ||
| initialState.serializedSearchSource, | ||
| initialState.fieldSpecs |
Contributor
Author
There was a problem hiding this comment.
Here, the embeddable factory supplies the field list for the data view backing the search source. This allows the data views service to forego a fields fetch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PoC the field specs that panels depend on are cached in the state of each panel, removing the need to load any field information through the
fieldsendpoint when the dashboard loads.Discover session — all fields this panel depends on are cached on the
searchsaved object. Then, they are used to hydrate the data view.Lens — all fields for all data views in the layers cached on the
lenssaved object. Then, they are used to hydrate the Lens "IndexPattern" objects which the panel depends on.