Skip to content

Conversation

@mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-onboarding Observability Onboarding Team Feature:Streams This is the label for the Streams Project Team:streams-program Team Label for Streams program labels Nov 9, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 9, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@tonyghiani
Copy link
Contributor

Let's make sure to test the partitioning suggestions work as expected, we face an issue fixed #242503 [Streams] Fix broken partitioning suggestions where the partitioning was broken and tests didn't catch the bug.

@mohamedhamed-ahmed
Copy link
Contributor Author

@thomheymann I added tests to cover most of the Partitioning tab, started thinking a bit on adding some tests for the AI suggestions part, let me know if you already had some thoughts on how to best handle this part in the test while working on it. I have already started drafting something down but any ideas would be great as well.

@elastic elastic deleted a comment from elasticmachine Nov 13, 2025
@thomheymann
Copy link
Contributor

@thomheymann I added tests to cover most of the Partitioning tab, started thinking a bit on adding some tests for the AI suggestions part, let me know if you already had some thoughts on how to best handle this part in the test while working on it. I have already started drafting something down but any ideas would be great as well.

@mohamedhamed-ahmed That's great, thanks for taking a look. What kind of tests are you thinking of adding? Would these be functional tests or unit tests? When it comes to functional tests the only way I can see them working would be to mock the AI calls. So it would be ES: real, Kibana: real, but AI connector with mocked response.

Do you have any other ideas how to approach testing for AI features?

@mohamedhamed-ahmed
Copy link
Contributor Author

When it comes to functional tests the only way I can see them working would be to mock the AI calls. So it would be ES: real, Kibana: real, but AI connector with mocked response.

This is exactly what I started putting in place, will be mocking some AI responses and test the flow of editing suggestions, accepting, rejecting, regenerating and also some validations like same names or empty names for example.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Scout: [ platform / streams_app ] plugin / serverless-oblt - Stream data routing - preview table cell actions - should create equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / serverless-oblt - Stream data routing - preview table cell actions - should create equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / serverless-oblt - Stream data routing - preview table cell actions - should create not-equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / serverless-oblt - Stream data routing - preview table cell actions - should create not-equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / should create equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / should create equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / should create not-equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / should create not-equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / stateful - Stream data routing - preview table cell actions - should create equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / stateful - Stream data routing - preview table cell actions - should create equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / stateful - Stream data routing - preview table cell actions - should create not-equals condition using cell action
  • [job] [logs] Scout: [ platform / streams_app ] plugin / stateful - Stream data routing - preview table cell actions - should create not-equals condition using cell action

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 940.3KB 941.2KB +847.0B
Unknown metric groups

ESLint disabled in files

id before after diff
streamsApp 10 11 +1

Total ESLint disabled count

id before after diff
streamsApp 27 28 +1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team Team:streams-program Team Label for Streams program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants