-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Streams] Add tests for partitioning tab #242364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Streams] Add tests for partitioning tab #242364
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
|
Let's make sure to test the partitioning suggestions work as expected, we face an issue fixed #242503 [Streams] Fix broken partitioning suggestions where the partitioning was broken and tests didn't catch the bug. |
|
@thomheymann I added tests to cover most of the Partitioning tab, started thinking a bit on adding some tests for the AI suggestions part, let me know if you already had some thoughts on how to best handle this part in the test while working on it. I have already started drafting something down but any ideas would be great as well. |
@mohamedhamed-ahmed That's great, thanks for taking a look. What kind of tests are you thinking of adding? Would these be functional tests or unit tests? When it comes to functional tests the only way I can see them working would be to mock the AI calls. So it would be ES: real, Kibana: real, but AI connector with mocked response. Do you have any other ideas how to approach testing for AI features? |
This is exactly what I started putting in place, will be mocking some AI responses and test the flow of editing suggestions, accepting, rejecting, regenerating and also some validations like same names or empty names for example. |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History |
part of https://github.com/elastic/streams-program/issues/573