Skip to content

Commit f06483a

Browse files
authored
Merge pull request #15 from elgentos/php84-compat
PHP 8.4 compatibility
2 parents fe06728 + a3f583f commit f06483a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/Api/ConfigurationInterface.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ interface ConfigurationInterface
88
CONFIG_RUMVISION_TRACKING_ID = 'elgentos_rumvision/general/tracking_id',
99
CONFIG_RUMVISION_HOST_NAME = 'elgentos_rumvision/general/hostname';
1010

11-
public function isEnabled(int $storeId = null): bool;
11+
public function isEnabled(?int $storeId = null): bool;
1212

13-
public function getTrackingId(int $storeId = null) :string;
13+
public function getTrackingId(?int $storeId = null) :string;
1414

15-
public function getHostName(int $storeId = null) :string;
15+
public function getHostName(?int $storeId = null) :string;
1616

17-
}
17+
}

src/Model/Config.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function __construct(
2121
private State $appState,
2222
) {}
2323

24-
public function isEnabled(int $storeId = null): bool
24+
public function isEnabled(?int $storeId = null): bool
2525
{
2626
if ($this->appState->getMode() === State::MODE_DEVELOPER) {
2727
// Don't run in developer mode
@@ -35,7 +35,7 @@ public function isEnabled(int $storeId = null): bool
3535
);
3636
}
3737

38-
public function getTrackingId(int $storeId = null): string
38+
public function getTrackingId(?int $storeId = null): string
3939
{
4040
return (string)$this->config->getValue(
4141
self::CONFIG_RUMVISION_TRACKING_ID,
@@ -44,7 +44,7 @@ public function getTrackingId(int $storeId = null): string
4444
);
4545
}
4646

47-
public function getHostName(int $storeId = null): string
47+
public function getHostName(?int $storeId = null): string
4848
{
4949
return (string)$this->config->getValue(
5050
self::CONFIG_RUMVISION_HOST_NAME,

0 commit comments

Comments
 (0)